diff options
Diffstat (limited to 'progs')
| -rw-r--r-- | progs/egl/eglgears.c | 3 | ||||
| -rw-r--r-- | progs/egl/eglscreen.c | 3 | ||||
| -rw-r--r-- | progs/rbug/simple_server.c | 4 | ||||
| -rw-r--r-- | progs/samples/olympic.c | 20 | ||||
| -rw-r--r-- | progs/samples/overlay.c | 18 | ||||
| -rw-r--r-- | progs/samples/rgbtoppm.c | 31 | ||||
| -rw-r--r-- | progs/samples/sphere.c | 30 | ||||
| -rw-r--r-- | progs/samples/star.c | 20 | ||||
| -rw-r--r-- | progs/samples/stretch.c | 20 | ||||
| -rw-r--r-- | progs/samples/wave.c | 2 | ||||
| -rw-r--r-- | progs/tests/getprocaddress.c | 2 | ||||
| -rw-r--r-- | progs/tests/vparray.c | 13 | ||||
| -rw-r--r-- | progs/vp/vp-tris.c | 3 | 
13 files changed, 93 insertions, 76 deletions
| diff --git a/progs/egl/eglgears.c b/progs/egl/eglgears.c index 052d0f9e25..2d9b8cac7f 100644 --- a/progs/egl/eglgears.c +++ b/progs/egl/eglgears.c @@ -374,7 +374,8 @@ main(int argc, char *argv[])  	EGLint screenAttribs[10];  	EGLModeMESA mode[MAX_MODES];  	EGLScreenMESA screen; -	EGLint count, chosenMode; +	EGLint count; +	EGLint chosenMode = 0;  	GLboolean printInfo = GL_FALSE;  	EGLint width = 0, height = 0; diff --git a/progs/egl/eglscreen.c b/progs/egl/eglscreen.c index 47b3ce3366..520f76ea03 100644 --- a/progs/egl/eglscreen.c +++ b/progs/egl/eglscreen.c @@ -52,7 +52,8 @@ main(int argc, char *argv[])  	EGLint screenAttribs[10];  	EGLModeMESA mode[MAX_MODES];  	EGLScreenMESA screen; -	EGLint count, chosenMode; +	EGLint count; +	EGLint chosenMode = 0;  	EGLint width = 0, height = 0;  	d = eglGetDisplay(EGL_DEFAULT_DISPLAY); diff --git a/progs/rbug/simple_server.c b/progs/rbug/simple_server.c index 04380c3310..3a842c06c4 100644 --- a/progs/rbug/simple_server.c +++ b/progs/rbug/simple_server.c @@ -29,7 +29,7 @@  #include "rbug/rbug.h" -static void wait() +static void rbug_wait()  {     int s = u_socket_listen_on_port(13370);     int c = u_socket_accept(s); @@ -57,6 +57,6 @@ static void wait()  int main(int argc, char** argv)  { -   wait(); +   rbug_wait();     return 0;  } diff --git a/progs/samples/olympic.c b/progs/samples/olympic.c index 5385e48702..209a8c141b 100644 --- a/progs/samples/olympic.c +++ b/progs/samples/olympic.c @@ -74,7 +74,7 @@ int iters[RINGS];  GLuint theTorus; -void FillTorus(float rc, int numc, float rt, int numt) +static void FillTorus(float rc, int numc, float rt, int numt)  {      int i, j, k;      double s, t; @@ -106,7 +106,7 @@ void FillTorus(float rc, int numc, float rt, int numt)      }  } -float Clamp(int iters_left, float t) +static float Clamp(int iters_left, float t)  {      if (iters_left < 3) {  	return 0.0; @@ -114,7 +114,7 @@ float Clamp(int iters_left, float t)      return (iters_left-2)*t/iters_left;  } -void DrawScene(void) +static void DrawScene(void)  {      int i, j;      GLboolean goIdle; @@ -172,7 +172,7 @@ void DrawScene(void)      }  } -float MyRand(void) +static float MyRand(void)  {     return 10.0 * ( (float) rand() / (float) RAND_MAX - 0.5 );  } @@ -181,12 +181,12 @@ float MyRand(void)  #define GLUTCALLBACK  #endif -void GLUTCALLBACK glut_post_redisplay_p(void) +static void GLUTCALLBACK glut_post_redisplay_p(void)  {        glutPostRedisplay();  } -void ReInit(void) +static void ReInit(void)  {      int i;      float deviation; @@ -206,7 +206,7 @@ void ReInit(void)      glutIdleFunc(glut_post_redisplay_p);  } -void Init(void) +static void Init(void)  {      float base, height;      float aspect, x, y; @@ -312,13 +312,13 @@ void Init(void)      glMatrixMode(GL_MODELVIEW);  } -void Reshape(int width, int height) +static void Reshape(int width, int height)  {      glViewport(0, 0, width, height);  } -void Key(unsigned char key, int x, int y) +static void Key(unsigned char key, int x, int y)  {      switch (key) { @@ -330,7 +330,7 @@ void Key(unsigned char key, int x, int y)      }  } -GLenum Args(int argc, char **argv) +static GLenum Args(int argc, char **argv)  {      GLint i; diff --git a/progs/samples/overlay.c b/progs/samples/overlay.c index 23b5a4793b..6087cef281 100644 --- a/progs/samples/overlay.c +++ b/progs/samples/overlay.c @@ -69,19 +69,19 @@ starRec stars[MAXSTARS];  float sinTable[MAXANGLES]; -float Sin(float angle) +static float Sin(float angle)  {      return (sinTable[(GLint)angle]);  } -float Cos(float angle) +static float Cos(float angle)  {      return (sinTable[((GLint)angle+(MAXANGLES/4))%MAXANGLES]);  } -void NewStar(GLint n, GLint d) +static void NewStar(GLint n, GLint d)  {      if (rand()%4 == 0) { @@ -103,7 +103,7 @@ void NewStar(GLint n, GLint d)      }  } -void RotatePoint(float *x, float *y, float rotation) +static void RotatePoint(float *x, float *y, float rotation)  {      float tmpX, tmpY; @@ -113,7 +113,7 @@ void RotatePoint(float *x, float *y, float rotation)      *y = tmpY;  } -void MoveStars(void) +static void MoveStars(void)  {      float offset;      GLint n; @@ -134,7 +134,7 @@ void MoveStars(void)      }  } -GLenum StarPoint(GLint n) +static GLenum StarPoint(GLint n)  {      float x0, y0, x1, y1, width;      GLint i; @@ -182,7 +182,7 @@ GLenum StarPoint(GLint n)      }  } -void ShowStars(void) +static void ShowStars(void)  {      GLint n; @@ -221,7 +221,7 @@ static void Init(void)      glDisable(GL_DITHER);  } -void Reshape(int width, int height) +static void Reshape(int width, int height)  {      windW = (GLint)width; @@ -262,7 +262,7 @@ static void Key(unsigned char key, int x, int y)      }  } -void Idle(void) +static void Idle(void)  {      if (overlayInit == GL_FALSE) { diff --git a/progs/samples/rgbtoppm.c b/progs/samples/rgbtoppm.c index dcb74228df..403578ef42 100644 --- a/progs/samples/rgbtoppm.c +++ b/progs/samples/rgbtoppm.c @@ -3,6 +3,7 @@  /* texload is a simplistic routine for reading an SGI .rgb image file. */ +#include <assert.h>  #include <stdio.h>  #include <stdlib.h>   #include <string.h> @@ -25,7 +26,7 @@ typedef struct _ImageRec {      int *rowSize;  } ImageRec; -void +static void  rgbtorgb(unsigned char *r,unsigned char *g,unsigned char *b,unsigned char *l,int n) {      while(n--) {          l[0] = r[0]; @@ -72,6 +73,7 @@ static ImageRec *ImageOpen(char *fileName)      ImageRec *image;      int swapFlag;      int x; +    int result;      endianTest.testWord = 1;      if (endianTest.testByte[0] == 1) { @@ -90,7 +92,8 @@ static ImageRec *ImageOpen(char *fileName)          return NULL;      } -    fread(image, 1, 12, image->file); +    result = fread(image, 1, 12, image->file); +    assert(result == 12);      if (swapFlag) {          ConvertShort(&image->imagic, 1); @@ -117,8 +120,10 @@ static ImageRec *ImageOpen(char *fileName)          }          image->rleEnd = 512 + (2 * x);          fseek(image->file, 512, SEEK_SET); -        fread(image->rowStart, 1, x, image->file); -        fread(image->rowSize, 1, x, image->file); +        result = fread(image->rowStart, 1, x, image->file); +        assert(result == x); +        result = fread(image->rowSize, 1, x, image->file); +        assert(result == x);          if (swapFlag) {              ConvertUint(image->rowStart, x/(int) sizeof(unsigned));              ConvertUint((unsigned *)image->rowSize, x/(int) sizeof(int)); @@ -138,11 +143,13 @@ static void  ImageGetRow(ImageRec *image, unsigned char *buf, int y, int z) {      unsigned char *iPtr, *oPtr, pixel;      int count; +    int result;      if ((image->type & 0xFF00) == 0x0100) {          fseek(image->file, (long) image->rowStart[y+z*image->ysize], SEEK_SET); -        fread(image->tmp, 1, (unsigned int)image->rowSize[y+z*image->ysize], -              image->file); +        result = fread(image->tmp, 1, (unsigned int)image->rowSize[y+z*image->ysize], +                       image->file); +        assert(result == (unsigned int)image->rowSize[y+z*image->ysize]);          iPtr = image->tmp;          oPtr = buf; @@ -166,11 +173,13 @@ ImageGetRow(ImageRec *image, unsigned char *buf, int y, int z) {      } else {          fseek(image->file, 512+(y*image->xsize)+(z*image->xsize*image->ysize),                SEEK_SET); -        fread(buf, 1, image->xsize, image->file); +        result = fread(buf, 1, image->xsize, image->file); +        assert(result == image->xsize);      }  } -GLubyte * +#if 0 +static GLubyte *  read_alpha_texture(char *name, int *width, int *height)  {      unsigned char *base, *lptr; @@ -199,8 +208,9 @@ read_alpha_texture(char *name, int *width, int *height)      return (unsigned char *) base;  } +#endif -GLubyte * +static GLubyte *  read_rgb_texture(char *name, int *width, int *height)  {      unsigned char *base, *ptr; @@ -261,7 +271,8 @@ read_rgb_texture(char *name, int *width, int *height)  int main(int argc, char **argv)  { -	int width, height; +	int width = 0; +	int height = 0;  	GLubyte *data;          char buff[32];          int n; diff --git a/progs/samples/sphere.c b/progs/samples/sphere.c index 7d0508dee9..23d4fe32c0 100644 --- a/progs/samples/sphere.c +++ b/progs/samples/sphere.c @@ -445,7 +445,7 @@ GLfloat identity[16] = {  }; -void BuildCylinder(int numEdges) +static void BuildCylinder(int numEdges)  {      int i, top = 1.0, bottom = -1.0;      float x[100], y[100], angle; @@ -481,7 +481,7 @@ void BuildCylinder(int numEdges)      glEndList();  } -void BuildTorus(float rc, int numc, float rt, int numt) +static void BuildTorus(float rc, int numc, float rt, int numt)  {      int i, j, k;      double s, t; @@ -515,7 +515,7 @@ void BuildTorus(float rc, int numc, float rt, int numt)      glEndList();  } -void BuildCage(void) +static void BuildCage(void)  {      int i;      float inc; @@ -609,7 +609,7 @@ void BuildCage(void)      glEndList();  } -void BuildCube(void) +static void BuildCube(void)  {      int i, j; @@ -628,7 +628,7 @@ void BuildCube(void)      glEndList();  } -void BuildLists(void) +static void BuildLists(void)  {      cube = glGenLists(1); @@ -646,7 +646,7 @@ void BuildLists(void)      genericObject = torus;  } -void SetDefaultSettings(void) +static void SetDefaultSettings(void)  {      magFilter = nnearest; @@ -657,7 +657,7 @@ void SetDefaultSettings(void)      autoRotate = GL_TRUE;  } -unsigned char *AlphaPadImage(int bufSize, unsigned char *inData, int alpha) +static unsigned char *AlphaPadImage(int bufSize, unsigned char *inData, int alpha)  {      unsigned char *outData, *out_ptr, *in_ptr;      int i; @@ -677,7 +677,7 @@ unsigned char *AlphaPadImage(int bufSize, unsigned char *inData, int alpha)      return outData;  } -void Init(void) +static void Init(void)  {      float ambient[] = {0.0, 0.0, 0.0, 1.0};      float diffuse[] = {1.0, 1.0, 1.0, 1.0}; @@ -753,7 +753,7 @@ void Init(void)      BuildLists();  } -void ReInit(void) +static void ReInit(void)  {      if (genericObject == torus) {  	glEnable(GL_DEPTH_TEST); @@ -773,7 +773,7 @@ void ReInit(void)      glTexEnvfv(GL_TEXTURE_ENV, GL_TEXTURE_ENV_MODE, textureEnvironment);  } -void Draw(void) +static void Draw(void)  {      glClear(GL_COLOR_BUFFER_BIT|GL_DEPTH_BUFFER_BIT); @@ -806,7 +806,7 @@ void Draw(void)      glutSwapBuffers();  } -void Reshape(int width, int height) +static void Reshape(int width, int height)  {      W = width;      H = height; @@ -818,7 +818,7 @@ void Reshape(int width, int height)      glMatrixMode(GL_MODELVIEW);  } -void Idle(void) +static void Idle(void)  {     static double t0 = -1.;     double t, dt; @@ -833,7 +833,7 @@ void Idle(void)     glutPostRedisplay();  } -void Key2(int key, int x, int y) +static void Key2(int key, int x, int y)  {      switch (key) { @@ -863,7 +863,7 @@ void Key2(int key, int x, int y)      glutPostRedisplay();  } -void Key(unsigned char key, int x, int y) +static void Key(unsigned char key, int x, int y)  {      switch (key) { @@ -950,7 +950,7 @@ void Key(unsigned char key, int x, int y)      glutPostRedisplay();  } -GLenum Args(int argc, char **argv) +static GLenum Args(int argc, char **argv)  {      GLint i; diff --git a/progs/samples/star.c b/progs/samples/star.c index 2cf470e2a2..2c44ebfd49 100644 --- a/progs/samples/star.c +++ b/progs/samples/star.c @@ -67,19 +67,19 @@ starRec stars[MAXSTARS];  float sinTable[MAXANGLES]; -float Sin(float angle) +static float Sin(float angle)  {      return (sinTable[(GLint)angle]);  } -float Cos(float angle) +static float Cos(float angle)  {      return (sinTable[((GLint)angle+(MAXANGLES/4))%MAXANGLES]);  } -void NewStar(GLint n, GLint d) +static void NewStar(GLint n, GLint d)  {      if (rand()%4 == 0) { @@ -101,7 +101,7 @@ void NewStar(GLint n, GLint d)      }  } -void RotatePoint(float *x, float *y, float rotation) +static void RotatePoint(float *x, float *y, float rotation)  {      float tmpX, tmpY; @@ -111,7 +111,7 @@ void RotatePoint(float *x, float *y, float rotation)      *y = tmpY;  } -void MoveStars(void) +static void MoveStars(void)  {      float offset;      GLint n; @@ -142,7 +142,7 @@ void MoveStars(void)      }  } -GLenum StarPoint(GLint n) +static GLenum StarPoint(GLint n)  {      float x0, y0, x1, y1, width;      GLint i; @@ -190,7 +190,7 @@ GLenum StarPoint(GLint n)      }  } -void ShowStars(void) +static void ShowStars(void)  {      GLint n; @@ -229,7 +229,7 @@ static void Init(void)      glDisable(GL_DITHER);  } -void Reshape(int width, int height) +static void Reshape(int width, int height)  {      windW = (GLint)width; @@ -260,7 +260,7 @@ static void Key(unsigned char key, int x, int y)      }  } -void Draw(void) +static void Draw(void)  {      MoveStars(); @@ -307,7 +307,7 @@ static GLenum Args(int argc, char **argv)  #define GLUTCALLBACK  #endif -void GLUTCALLBACK glut_post_redisplay_p(void) +static void GLUTCALLBACK glut_post_redisplay_p(void)  {        glutPostRedisplay();  } diff --git a/progs/samples/stretch.c b/progs/samples/stretch.c index 1fd015d794..11201dca23 100644 --- a/progs/samples/stretch.c +++ b/progs/samples/stretch.c @@ -67,7 +67,7 @@ int cCount, cIndex[2], cStep;  GLenum op = OP_NOOP; -void DrawImage(void) +static void DrawImage(void)  {      glRasterPos2i(0, 0); @@ -84,7 +84,7 @@ void DrawImage(void)  		 image->data);  } -void DrawPoint(void) +static void DrawPoint(void)  {      int i; @@ -102,7 +102,7 @@ void DrawPoint(void)      }  } -void InitVList(void) +static void InitVList(void)  {      vList[0].x = 0.0; @@ -141,7 +141,7 @@ void InitVList(void)      vList[4].tY = cList[0].y / (float)imageSizeY;  } -void ScaleImage(int sizeX, int sizeY) +static void ScaleImage(int sizeX, int sizeY)  {      GLubyte *buf; @@ -154,7 +154,7 @@ void ScaleImage(int sizeX, int sizeY)      image->sizeY = sizeY;  } -void SetPoint(int x, int y) +static void SetPoint(int x, int y)  {      cList[cCount].x = (float)x; @@ -162,7 +162,7 @@ void SetPoint(int x, int y)      cCount++;  } -void Stretch(void) +static void Stretch(void)  {      glBegin(GL_TRIANGLES); @@ -221,7 +221,7 @@ void Stretch(void)      }  } -void Key(unsigned char key, int x, int y) +static void Key(unsigned char key, int x, int y)  {      switch (key) { @@ -245,7 +245,7 @@ void Key(unsigned char key, int x, int y)      glutPostRedisplay();  } -void Mouse(int button, int state, int mouseX, int mouseY) +static void Mouse(int button, int state, int mouseX, int mouseY)  {      if (state != GLUT_DOWN) @@ -263,7 +263,7 @@ void Mouse(int button, int state, int mouseX, int mouseY)      glutPostRedisplay();  } -void Animate(void) +static void Animate(void)  {      static double t0 = -1.;      double t, dt; @@ -322,7 +322,7 @@ static GLenum Args(int argc, char **argv)  #define GLUTCALLBACK  #endif -void GLUTCALLBACK glut_post_redisplay_p(void) +static void GLUTCALLBACK glut_post_redisplay_p(void)  {        glutPostRedisplay();  } diff --git a/progs/samples/wave.c b/progs/samples/wave.c index d3c4687459..396a6943e3 100644 --- a/progs/samples/wave.c +++ b/progs/samples/wave.c @@ -92,7 +92,7 @@ GLubyte contourTexture2[] = {  #endif -void GLUTCALLBACK glut_post_redisplay_p(void) +static void GLUTCALLBACK glut_post_redisplay_p(void)  {      static double t0 = -1.;      double t, dt; diff --git a/progs/tests/getprocaddress.c b/progs/tests/getprocaddress.c index b905eeaf81..e699baf44b 100644 --- a/progs/tests/getprocaddress.c +++ b/progs/tests/getprocaddress.c @@ -1188,7 +1188,7 @@ exercise_buffer_objects(enum Map_Buffer_Usage usage)     GLuint bufferID;     GLint bufferMapped;     static GLubyte data[BUFFER_DATA_SIZE] = {0}; -   float *dataPtr; +   float *dataPtr = NULL;     /* Get the function pointers we need.  These are from      * GL_ARB_vertex_buffer_object and are required in all diff --git a/progs/tests/vparray.c b/progs/tests/vparray.c index af9b62d33e..fe168c6cd5 100644 --- a/progs/tests/vparray.c +++ b/progs/tests/vparray.c @@ -37,13 +37,16 @@ static void read_surface( char *filename )     }     numverts = 0; -   while (!feof(f) && numverts < MAXVERTS) { -      fscanf( f, "%f %f %f  %f %f %f", -	      &data[numverts][0], &data[numverts][1], &data[numverts][2], -	      &data[numverts][3], &data[numverts][4], &data[numverts][5] ); +   while (numverts < MAXVERTS) { +      int result; +      result = fscanf( f, "%f %f %f  %f %f %f", +	               &data[numverts][0], &data[numverts][1], &data[numverts][2], +	               &data[numverts][3], &data[numverts][4], &data[numverts][5] ); +      if (result == EOF) { +         break; +      }        numverts++;     } -   numverts--;     printf("%d vertices, %d triangles\n", numverts, numverts-2);     printf("data = %p\n", (void *) data); diff --git a/progs/vp/vp-tris.c b/progs/vp/vp-tris.c index 29cd027b00..09236c296f 100644 --- a/progs/vp/vp-tris.c +++ b/progs/vp/vp-tris.c @@ -96,7 +96,8 @@ static void Init( void )        exit(1);     } -   sz = (GLuint) fread(buf, 1, sizeof(buf), f); +   sz = (GLuint) fread(buf, 1, sizeof(buf) - 1, f); +   buf[sizeof(buf) - 1] = '\0';     if (!feof(f)) {        fprintf(stderr, "file too long\n");        fclose(f); | 
