From ad87f2ddc7e6b95e3dd5bbe4d2b19703d305c74e Mon Sep 17 00:00:00 2001 From: Ian Romanick Date: Thu, 18 Nov 2010 17:11:17 -0800 Subject: glsl: Make is_zero and is_one virtual methods of ir_rvalue This eliminates the need in some cames to validate that an rvalue is an ir_constant before checking to see if it's 0 or 1. --- src/glsl/ir.h | 47 ++++++++++++++++++++++++++--------------------- 1 file changed, 26 insertions(+), 21 deletions(-) (limited to 'src/glsl/ir.h') diff --git a/src/glsl/ir.h b/src/glsl/ir.h index 3fc834906a..3ea7301f47 100644 --- a/src/glsl/ir.h +++ b/src/glsl/ir.h @@ -171,6 +171,30 @@ public: return NULL; } + /** + * Determine if an r-value has the value zero + * + * The base implementation of this function always returns \c false. The + * \c ir_constant class over-rides this function to return \c true \b only + * for vector and scalar types that have all elements set to the value + * zero (or \c false for booleans). + * + * \sa ir_constant::has_value, ir_rvalue::is_one + */ + virtual bool is_zero() const; + + /** + * Determine if an r-value has the value one + * + * The base implementation of this function always returns \c false. The + * \c ir_constant class over-rides this function to return \c true \b only + * for vector and scalar types that have all elements set to the value + * one (or \c true for booleans). + * + * \sa ir_constant::has_value, ir_rvalue::is_zero + */ + virtual bool is_one() const; + protected: ir_rvalue(); }; @@ -1460,27 +1484,8 @@ public: */ bool has_value(const ir_constant *) const; - /** - * Determine if a constant has the value zero - * - * \note - * This function always returns \c false for constants that are not - * scalars or vectors. - * - * \sa ir_constant::has_value, ir_constant::is_one - */ - bool is_zero() const; - - /** - * Determine if a constant has the value one - * - * \note - * This function always returns \c false for constants that are not - * scalars or vectors. - * - * \sa ir_constant::has_value, ir_constant::is_zero - */ - bool is_one() const; + virtual bool is_zero() const; + virtual bool is_one() const; /** * Value of the constant. -- cgit v1.2.3