From 04e88f469cf6c338ba04640738865b59e160c3d4 Mon Sep 17 00:00:00 2001
From: Brian <brian.paul@tungstengraphics.com>
Date: Sun, 9 Dec 2007 20:45:20 -0700
Subject: added null ptr check in draw_destroy() for rasterizer stage

---
 src/mesa/pipe/draw/draw_context.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

(limited to 'src/mesa/pipe')

diff --git a/src/mesa/pipe/draw/draw_context.c b/src/mesa/pipe/draw/draw_context.c
index 6792a06a4e..33727e6547 100644
--- a/src/mesa/pipe/draw/draw_context.c
+++ b/src/mesa/pipe/draw/draw_context.c
@@ -102,7 +102,8 @@ void draw_destroy( struct draw_context *draw )
    draw->pipeline.cull->destroy( draw->pipeline.cull );
    draw->pipeline.feedback->destroy( draw->pipeline.feedback );
    draw->pipeline.validate->destroy( draw->pipeline.validate );
-   draw->pipeline.rasterize->destroy( draw->pipeline.rasterize );
+   if (draw->pipeline.rasterize)
+      draw->pipeline.rasterize->destroy( draw->pipeline.rasterize );
    FREE( draw->vcache.vertex[0] ); /* Frees all the vertices. */
    FREE( draw );
 }
-- 
cgit v1.2.3


From 98848382731b71a51e4a80f1820f009e70f06a25 Mon Sep 17 00:00:00 2001
From: Brian <brian.paul@tungstengraphics.com>
Date: Sun, 9 Dec 2007 21:10:39 -0700
Subject: Fix looping for multi-color buffer writing.

---
 src/mesa/pipe/softpipe/sp_context.h        | 2 +-
 src/mesa/pipe/softpipe/sp_quad.c           | 2 +-
 src/mesa/pipe/softpipe/sp_quad_blend.c     | 6 ++++--
 src/mesa/pipe/softpipe/sp_quad_bufloop.c   | 4 +---
 src/mesa/pipe/softpipe/sp_quad_colormask.c | 3 ++-
 src/mesa/pipe/softpipe/sp_quad_output.c    | 3 ++-
 6 files changed, 11 insertions(+), 9 deletions(-)

(limited to 'src/mesa/pipe')

diff --git a/src/mesa/pipe/softpipe/sp_context.h b/src/mesa/pipe/softpipe/sp_context.h
index d4763a98c6..b97cdc52c6 100644
--- a/src/mesa/pipe/softpipe/sp_context.h
+++ b/src/mesa/pipe/softpipe/sp_context.h
@@ -154,7 +154,7 @@ struct softpipe_context {
    struct draw_stage *setup;
    struct draw_stage *vbuf;
 
-   struct pipe_surface *cbuf;      /**< current color buffer (one of cbufs) */
+   uint current_cbuf;      /**< current color buffer being written to */
 
    struct softpipe_tile_cache *cbuf_cache[PIPE_MAX_COLOR_BUFS];
    struct softpipe_tile_cache *zbuf_cache;
diff --git a/src/mesa/pipe/softpipe/sp_quad.c b/src/mesa/pipe/softpipe/sp_quad.c
index e0327c4cf9..6330465a8b 100644
--- a/src/mesa/pipe/softpipe/sp_quad.c
+++ b/src/mesa/pipe/softpipe/sp_quad.c
@@ -77,7 +77,7 @@ sp_build_quad_pipeline(struct softpipe_context *sp)
 
    if (sp->framebuffer.num_cbufs == 1) {
       /* the usual case: write to exactly one colorbuf */
-      sp->cbuf = sp->framebuffer.cbufs[0];
+      sp->current_cbuf = 0;
    }
    else {
       /* insert bufloop stage */
diff --git a/src/mesa/pipe/softpipe/sp_quad_blend.c b/src/mesa/pipe/softpipe/sp_quad_blend.c
index 696e252af1..76a0873fc5 100644
--- a/src/mesa/pipe/softpipe/sp_quad_blend.c
+++ b/src/mesa/pipe/softpipe/sp_quad_blend.c
@@ -107,7 +107,8 @@ logicop_quad(struct quad_stage *qs, struct quad_header *quad)
    uint *dst4 = (uint *) dst;
    uint *res4 = (uint *) res;
    struct softpipe_cached_tile *
-      tile = sp_get_cached_tile(softpipe, softpipe->cbuf_cache[0],
+      tile = sp_get_cached_tile(softpipe,
+                                softpipe->cbuf_cache[softpipe->current_cbuf],
                                 quad->x0, quad->y0);
    uint i, j;
 
@@ -224,7 +225,8 @@ blend_quad(struct quad_stage *qs, struct quad_header *quad)
    static const float one[4] = { 1, 1, 1, 1 };
    float source[4][QUAD_SIZE], dest[4][QUAD_SIZE];
    struct softpipe_cached_tile *tile
-      = sp_get_cached_tile(softpipe, softpipe->cbuf_cache[0],
+      = sp_get_cached_tile(softpipe,
+                           softpipe->cbuf_cache[softpipe->current_cbuf],
                            quad->x0, quad->y0);
    uint i, j;
 
diff --git a/src/mesa/pipe/softpipe/sp_quad_bufloop.c b/src/mesa/pipe/softpipe/sp_quad_bufloop.c
index aac70e2b04..e704b4043c 100644
--- a/src/mesa/pipe/softpipe/sp_quad_bufloop.c
+++ b/src/mesa/pipe/softpipe/sp_quad_bufloop.c
@@ -30,7 +30,7 @@ cbuf_loop_quad(struct quad_stage *qs, struct quad_header *quad)
 
    for (i = 0; i < softpipe->framebuffer.num_cbufs; i++) {
       /* set current cbuffer */
-      softpipe->cbuf = softpipe->framebuffer.cbufs[i];
+      softpipe->current_cbuf = i;
 
       /* pass blended quad to next stage */
       qs->next->run(qs->next, quad);
@@ -38,8 +38,6 @@ cbuf_loop_quad(struct quad_stage *qs, struct quad_header *quad)
       /* restore quad's colors for next buffer */
       memcpy(quad->outputs.color, tmp, sizeof(tmp));
    }
-
-   softpipe->cbuf = NULL; /* prevent accidental use */
 }
 
 
diff --git a/src/mesa/pipe/softpipe/sp_quad_colormask.c b/src/mesa/pipe/softpipe/sp_quad_colormask.c
index c585aa3edd..f5e0a32d1b 100644
--- a/src/mesa/pipe/softpipe/sp_quad_colormask.c
+++ b/src/mesa/pipe/softpipe/sp_quad_colormask.c
@@ -50,7 +50,8 @@ colormask_quad(struct quad_stage *qs, struct quad_header *quad)
    float dest[4][QUAD_SIZE];
    struct softpipe_cached_tile *tile
       = sp_get_cached_tile(softpipe,
-                           softpipe->cbuf_cache[0], quad->x0, quad->y0);
+                           softpipe->cbuf_cache[softpipe->current_cbuf],
+                           quad->x0, quad->y0);
    uint i, j;
 
    /* get/swizzle dest colors */
diff --git a/src/mesa/pipe/softpipe/sp_quad_output.c b/src/mesa/pipe/softpipe/sp_quad_output.c
index cebfec18f7..f04a550e3d 100644
--- a/src/mesa/pipe/softpipe/sp_quad_output.c
+++ b/src/mesa/pipe/softpipe/sp_quad_output.c
@@ -43,7 +43,8 @@ output_quad(struct quad_stage *qs, struct quad_header *quad)
 {
    struct softpipe_context *softpipe = qs->softpipe;
    struct softpipe_cached_tile *tile
-      = sp_get_cached_tile(softpipe, softpipe->cbuf_cache[0],
+      = sp_get_cached_tile(softpipe,
+                           softpipe->cbuf_cache[softpipe->current_cbuf],
                            quad->x0, quad->y0);
    /* in-tile pos: */
    const int itx = quad->x0 % TILE_SIZE;
-- 
cgit v1.2.3


From 63e2ab83f6f3955c230bf71662136b34ff46dfe2 Mon Sep 17 00:00:00 2001
From: Brian <brian.paul@tungstengraphics.com>
Date: Sun, 9 Dec 2007 21:44:26 -0700
Subject: use quadColor local var

---
 src/mesa/pipe/softpipe/sp_quad_alpha_test.c |  13 +-
 src/mesa/pipe/softpipe/sp_quad_blend.c      | 194 ++++++++++++++--------------
 src/mesa/pipe/softpipe/sp_quad_colormask.c  |   9 +-
 src/mesa/pipe/softpipe/sp_quad_coverage.c   |   3 +-
 src/mesa/pipe/softpipe/sp_quad_output.c     |   3 +-
 5 files changed, 114 insertions(+), 108 deletions(-)

(limited to 'src/mesa/pipe')

diff --git a/src/mesa/pipe/softpipe/sp_quad_alpha_test.c b/src/mesa/pipe/softpipe/sp_quad_alpha_test.c
index 6a9cf29e47..7b56bceba2 100644
--- a/src/mesa/pipe/softpipe/sp_quad_alpha_test.c
+++ b/src/mesa/pipe/softpipe/sp_quad_alpha_test.c
@@ -16,6 +16,7 @@ alpha_test_quad(struct quad_stage *qs, struct quad_header *quad)
    struct softpipe_context *softpipe = qs->softpipe;
    const float ref = softpipe->alpha_test->ref;
    unsigned passMask = 0x0, j;
+   const float *aaaa = quad->outputs.color[3];
 
    switch (softpipe->alpha_test->func) {
    case PIPE_FUNC_NEVER:
@@ -27,42 +28,42 @@ alpha_test_quad(struct quad_stage *qs, struct quad_header *quad)
        * passMask = (quad->outputs.color[3] <= vec4(ref));
        */
       for (j = 0; j < QUAD_SIZE; j++) {
-         if (quad->outputs.color[3][j] < ref) {
+         if (aaaa[j] < ref) {
             passMask |= (1 << j);
          }
       }
       break;
    case PIPE_FUNC_EQUAL:
       for (j = 0; j < QUAD_SIZE; j++) {
-         if (quad->outputs.color[3][j] == ref) {
+         if (aaaa[j] == ref) {
             passMask |= (1 << j);
          }
       }
       break;
    case PIPE_FUNC_LEQUAL:
       for (j = 0; j < QUAD_SIZE; j++) {
-         if (quad->outputs.color[3][j] <= ref) {
+         if (aaaa[j] <= ref) {
             passMask |= (1 << j);
          }
       }
       break;
    case PIPE_FUNC_GREATER:
       for (j = 0; j < QUAD_SIZE; j++) {
-         if (quad->outputs.color[3][j] > ref) {
+         if (aaaa[j] > ref) {
             passMask |= (1 << j);
          }
       }
       break;
    case PIPE_FUNC_NOTEQUAL:
       for (j = 0; j < QUAD_SIZE; j++) {
-         if (quad->outputs.color[3][j] != ref) {
+         if (aaaa[j] != ref) {
             passMask |= (1 << j);
          }
       }
       break;
    case PIPE_FUNC_GEQUAL:
       for (j = 0; j < QUAD_SIZE; j++) {
-         if (quad->outputs.color[3][j] >= ref) {
+         if (aaaa[j] >= ref) {
             passMask |= (1 << j);
          }
       }
diff --git a/src/mesa/pipe/softpipe/sp_quad_blend.c b/src/mesa/pipe/softpipe/sp_quad_blend.c
index 76a0873fc5..1843e20684 100644
--- a/src/mesa/pipe/softpipe/sp_quad_blend.c
+++ b/src/mesa/pipe/softpipe/sp_quad_blend.c
@@ -110,6 +110,7 @@ logicop_quad(struct quad_stage *qs, struct quad_header *quad)
       tile = sp_get_cached_tile(softpipe,
                                 softpipe->cbuf_cache[softpipe->current_cbuf],
                                 quad->x0, quad->y0);
+   float (*quadColor)[4] = quad->outputs.color;
    uint i, j;
 
    /* get/swizzle dest colors */
@@ -128,10 +129,10 @@ logicop_quad(struct quad_stage *qs, struct quad_header *quad)
       UNCLAMPED_FLOAT_TO_UBYTE(dst[j][2], dest[j][2]); /* P2 */
       UNCLAMPED_FLOAT_TO_UBYTE(dst[j][3], dest[j][3]); /* P3 */
 
-      UNCLAMPED_FLOAT_TO_UBYTE(src[j][0], quad->outputs.color[j][0]); /* P0 */
-      UNCLAMPED_FLOAT_TO_UBYTE(src[j][1], quad->outputs.color[j][1]); /* P1 */
-      UNCLAMPED_FLOAT_TO_UBYTE(src[j][2], quad->outputs.color[j][2]); /* P2 */
-      UNCLAMPED_FLOAT_TO_UBYTE(src[j][3], quad->outputs.color[j][3]); /* P3 */
+      UNCLAMPED_FLOAT_TO_UBYTE(src[j][0], quadColor[j][0]); /* P0 */
+      UNCLAMPED_FLOAT_TO_UBYTE(src[j][1], quadColor[j][1]); /* P1 */
+      UNCLAMPED_FLOAT_TO_UBYTE(src[j][2], quadColor[j][2]); /* P2 */
+      UNCLAMPED_FLOAT_TO_UBYTE(src[j][3], quadColor[j][3]); /* P3 */
    }
 
    switch (softpipe->blend->logicop_func) {
@@ -204,10 +205,10 @@ logicop_quad(struct quad_stage *qs, struct quad_header *quad)
    }
 
    for (j = 0; j < 4; j++) {
-      quad->outputs.color[j][0] = UBYTE_TO_FLOAT(res[j][0]);
-      quad->outputs.color[j][1] = UBYTE_TO_FLOAT(res[j][1]);
-      quad->outputs.color[j][2] = UBYTE_TO_FLOAT(res[j][2]);
-      quad->outputs.color[j][3] = UBYTE_TO_FLOAT(res[j][3]);
+      quadColor[j][0] = UBYTE_TO_FLOAT(res[j][0]);
+      quadColor[j][1] = UBYTE_TO_FLOAT(res[j][1]);
+      quadColor[j][2] = UBYTE_TO_FLOAT(res[j][2]);
+      quadColor[j][3] = UBYTE_TO_FLOAT(res[j][3]);
    }
 
    /* pass quad to next stage */
@@ -228,6 +229,7 @@ blend_quad(struct quad_stage *qs, struct quad_header *quad)
       = sp_get_cached_tile(softpipe,
                            softpipe->cbuf_cache[softpipe->current_cbuf],
                            quad->x0, quad->y0);
+   float (*quadColor)[4] = quad->outputs.color;
    uint i, j;
 
    if (softpipe->blend->logicop_enable) {
@@ -249,39 +251,39 @@ blend_quad(struct quad_stage *qs, struct quad_header *quad)
     */
    switch (softpipe->blend->rgb_src_factor) {
    case PIPE_BLENDFACTOR_ONE:
-      VEC4_COPY(source[0], quad->outputs.color[0]); /* R */
-      VEC4_COPY(source[1], quad->outputs.color[1]); /* G */
-      VEC4_COPY(source[2], quad->outputs.color[2]); /* B */
+      VEC4_COPY(source[0], quadColor[0]); /* R */
+      VEC4_COPY(source[1], quadColor[1]); /* G */
+      VEC4_COPY(source[2], quadColor[2]); /* B */
       break;
    case PIPE_BLENDFACTOR_SRC_COLOR:
-      VEC4_MUL(source[0], quad->outputs.color[0], quad->outputs.color[0]); /* R */
-      VEC4_MUL(source[1], quad->outputs.color[1], quad->outputs.color[1]); /* G */
-      VEC4_MUL(source[2], quad->outputs.color[2], quad->outputs.color[2]); /* B */
+      VEC4_MUL(source[0], quadColor[0], quadColor[0]); /* R */
+      VEC4_MUL(source[1], quadColor[1], quadColor[1]); /* G */
+      VEC4_MUL(source[2], quadColor[2], quadColor[2]); /* B */
       break;
    case PIPE_BLENDFACTOR_SRC_ALPHA:
       {
-         const float *alpha = quad->outputs.color[3];
-         VEC4_MUL(source[0], quad->outputs.color[0], alpha); /* R */
-         VEC4_MUL(source[1], quad->outputs.color[1], alpha); /* G */
-         VEC4_MUL(source[2], quad->outputs.color[2], alpha); /* B */
+         const float *alpha = quadColor[3];
+         VEC4_MUL(source[0], quadColor[0], alpha); /* R */
+         VEC4_MUL(source[1], quadColor[1], alpha); /* G */
+         VEC4_MUL(source[2], quadColor[2], alpha); /* B */
       }
       break;
    case PIPE_BLENDFACTOR_DST_COLOR:
-      VEC4_MUL(source[0], quad->outputs.color[0], dest[0]); /* R */
-      VEC4_MUL(source[1], quad->outputs.color[1], dest[1]); /* G */
-      VEC4_MUL(source[2], quad->outputs.color[2], dest[2]); /* B */
+      VEC4_MUL(source[0], quadColor[0], dest[0]); /* R */
+      VEC4_MUL(source[1], quadColor[1], dest[1]); /* G */
+      VEC4_MUL(source[2], quadColor[2], dest[2]); /* B */
       break;
    case PIPE_BLENDFACTOR_DST_ALPHA:
       {
          const float *alpha = dest[3];
-         VEC4_MUL(source[0], quad->outputs.color[0], alpha); /* R */
-         VEC4_MUL(source[1], quad->outputs.color[1], alpha); /* G */
-         VEC4_MUL(source[2], quad->outputs.color[2], alpha); /* B */
+         VEC4_MUL(source[0], quadColor[0], alpha); /* R */
+         VEC4_MUL(source[1], quadColor[1], alpha); /* G */
+         VEC4_MUL(source[2], quadColor[2], alpha); /* B */
       }
       break;
    case PIPE_BLENDFACTOR_SRC_ALPHA_SATURATE:
       {
-         const float *alpha = quad->outputs.color[3];
+         const float *alpha = quadColor[3];
          float diff[4];
          VEC4_SUB(diff, one, dest[3]);
          VEC4_MIN(source[0], alpha, diff); /* R */
@@ -293,20 +295,20 @@ blend_quad(struct quad_stage *qs, struct quad_header *quad)
       {
          float comp[4];
          VEC4_SCALAR(comp, softpipe->blend_color.color[0]); /* R */
-         VEC4_MUL(source[0], quad->outputs.color[0], comp); /* R */
+         VEC4_MUL(source[0], quadColor[0], comp); /* R */
          VEC4_SCALAR(comp, softpipe->blend_color.color[1]); /* G */
-         VEC4_MUL(source[1], quad->outputs.color[1], comp); /* G */
+         VEC4_MUL(source[1], quadColor[1], comp); /* G */
          VEC4_SCALAR(comp, softpipe->blend_color.color[2]); /* B */
-         VEC4_MUL(source[2], quad->outputs.color[2], comp); /* B */
+         VEC4_MUL(source[2], quadColor[2], comp); /* B */
       }
       break;
    case PIPE_BLENDFACTOR_CONST_ALPHA:
       {
          float alpha[4];
          VEC4_SCALAR(alpha, softpipe->blend_color.color[3]);
-         VEC4_MUL(source[0], quad->outputs.color[0], alpha); /* R */
-         VEC4_MUL(source[1], quad->outputs.color[1], alpha); /* G */
-         VEC4_MUL(source[2], quad->outputs.color[2], alpha); /* B */
+         VEC4_MUL(source[0], quadColor[0], alpha); /* R */
+         VEC4_MUL(source[1], quadColor[1], alpha); /* G */
+         VEC4_MUL(source[2], quadColor[2], alpha); /* B */
       }
       break;
    case PIPE_BLENDFACTOR_SRC1_COLOR:
@@ -323,41 +325,41 @@ blend_quad(struct quad_stage *qs, struct quad_header *quad)
    case PIPE_BLENDFACTOR_INV_SRC_COLOR:
       {
          float inv_comp[4];
-         VEC4_SUB(inv_comp, one, quad->outputs.color[0]); /* R */
-         VEC4_MUL(source[0], quad->outputs.color[0], inv_comp); /* R */
-         VEC4_SUB(inv_comp, one, quad->outputs.color[1]); /* G */
-         VEC4_MUL(source[1], quad->outputs.color[1], inv_comp); /* G */
-         VEC4_SUB(inv_comp, one, quad->outputs.color[2]); /* B */
-         VEC4_MUL(source[2], quad->outputs.color[2], inv_comp); /* B */
+         VEC4_SUB(inv_comp, one, quadColor[0]); /* R */
+         VEC4_MUL(source[0], quadColor[0], inv_comp); /* R */
+         VEC4_SUB(inv_comp, one, quadColor[1]); /* G */
+         VEC4_MUL(source[1], quadColor[1], inv_comp); /* G */
+         VEC4_SUB(inv_comp, one, quadColor[2]); /* B */
+         VEC4_MUL(source[2], quadColor[2], inv_comp); /* B */
       }
       break;
    case PIPE_BLENDFACTOR_INV_SRC_ALPHA:
       {
          float inv_alpha[4];
-         VEC4_SUB(inv_alpha, one, quad->outputs.color[3]);
-         VEC4_MUL(source[0], quad->outputs.color[0], inv_alpha); /* R */
-         VEC4_MUL(source[1], quad->outputs.color[1], inv_alpha); /* G */
-         VEC4_MUL(source[2], quad->outputs.color[2], inv_alpha); /* B */
+         VEC4_SUB(inv_alpha, one, quadColor[3]);
+         VEC4_MUL(source[0], quadColor[0], inv_alpha); /* R */
+         VEC4_MUL(source[1], quadColor[1], inv_alpha); /* G */
+         VEC4_MUL(source[2], quadColor[2], inv_alpha); /* B */
       }
       break;
    case PIPE_BLENDFACTOR_INV_DST_ALPHA:
       {
          float inv_alpha[4];
          VEC4_SUB(inv_alpha, one, dest[3]);
-         VEC4_MUL(source[0], quad->outputs.color[0], inv_alpha); /* R */
-         VEC4_MUL(source[1], quad->outputs.color[1], inv_alpha); /* G */
-         VEC4_MUL(source[2], quad->outputs.color[2], inv_alpha); /* B */
+         VEC4_MUL(source[0], quadColor[0], inv_alpha); /* R */
+         VEC4_MUL(source[1], quadColor[1], inv_alpha); /* G */
+         VEC4_MUL(source[2], quadColor[2], inv_alpha); /* B */
       }
       break;
    case PIPE_BLENDFACTOR_INV_DST_COLOR:
       {
          float inv_comp[4];
          VEC4_SUB(inv_comp, one, dest[0]); /* R */
-         VEC4_MUL(source[0], quad->outputs.color[0], inv_comp); /* R */
+         VEC4_MUL(source[0], quadColor[0], inv_comp); /* R */
          VEC4_SUB(inv_comp, one, dest[1]); /* G */
-         VEC4_MUL(source[1], quad->outputs.color[1], inv_comp); /* G */
+         VEC4_MUL(source[1], quadColor[1], inv_comp); /* G */
          VEC4_SUB(inv_comp, one, dest[2]); /* B */
-         VEC4_MUL(source[2], quad->outputs.color[2], inv_comp); /* B */
+         VEC4_MUL(source[2], quadColor[2], inv_comp); /* B */
       }
       break;
    case PIPE_BLENDFACTOR_INV_CONST_COLOR:
@@ -365,22 +367,22 @@ blend_quad(struct quad_stage *qs, struct quad_header *quad)
          float inv_comp[4];
          /* R */
          VEC4_SCALAR(inv_comp, 1.0f - softpipe->blend_color.color[0]);
-         VEC4_MUL(source[0], quad->outputs.color[0], inv_comp);
+         VEC4_MUL(source[0], quadColor[0], inv_comp);
          /* G */
          VEC4_SCALAR(inv_comp, 1.0f - softpipe->blend_color.color[1]);
-         VEC4_MUL(source[1], quad->outputs.color[1], inv_comp);
+         VEC4_MUL(source[1], quadColor[1], inv_comp);
          /* B */
          VEC4_SCALAR(inv_comp, 1.0f - softpipe->blend_color.color[2]);
-         VEC4_MUL(source[2], quad->outputs.color[2], inv_comp);
+         VEC4_MUL(source[2], quadColor[2], inv_comp);
       }
       break;
    case PIPE_BLENDFACTOR_INV_CONST_ALPHA:
       {
          float inv_alpha[4];
          VEC4_SCALAR(inv_alpha, 1.0f - softpipe->blend_color.color[3]);
-         VEC4_MUL(source[0], quad->outputs.color[0], inv_alpha); /* R */
-         VEC4_MUL(source[1], quad->outputs.color[1], inv_alpha); /* G */
-         VEC4_MUL(source[2], quad->outputs.color[2], inv_alpha); /* B */
+         VEC4_MUL(source[0], quadColor[0], inv_alpha); /* R */
+         VEC4_MUL(source[1], quadColor[1], inv_alpha); /* G */
+         VEC4_MUL(source[2], quadColor[2], inv_alpha); /* B */
       }
       break;
    case PIPE_BLENDFACTOR_INV_SRC1_COLOR:
@@ -398,24 +400,24 @@ blend_quad(struct quad_stage *qs, struct quad_header *quad)
     */
    switch (softpipe->blend->alpha_src_factor) {
    case PIPE_BLENDFACTOR_ONE:
-      VEC4_COPY(source[3], quad->outputs.color[3]); /* A */
+      VEC4_COPY(source[3], quadColor[3]); /* A */
       break;
    case PIPE_BLENDFACTOR_SRC_COLOR:
       /* fall-through */
    case PIPE_BLENDFACTOR_SRC_ALPHA:
       {
-         const float *alpha = quad->outputs.color[3];
-         VEC4_MUL(source[3], quad->outputs.color[3], alpha); /* A */
+         const float *alpha = quadColor[3];
+         VEC4_MUL(source[3], quadColor[3], alpha); /* A */
       }
       break;
    case PIPE_BLENDFACTOR_DST_COLOR:
       /* fall-through */
    case PIPE_BLENDFACTOR_DST_ALPHA:
-      VEC4_MUL(source[3], quad->outputs.color[3], dest[3]); /* A */
+      VEC4_MUL(source[3], quadColor[3], dest[3]); /* A */
       break;
    case PIPE_BLENDFACTOR_SRC_ALPHA_SATURATE:
       {
-         const float *alpha = quad->outputs.color[3];
+         const float *alpha = quadColor[3];
          float diff[4];
          VEC4_SUB(diff, one, dest[3]);
          VEC4_MIN(source[3], alpha, diff); /* A */
@@ -427,7 +429,7 @@ blend_quad(struct quad_stage *qs, struct quad_header *quad)
       {
          float comp[4];
          VEC4_SCALAR(comp, softpipe->blend_color.color[3]); /* A */
-         VEC4_MUL(source[3], quad->outputs.color[3], comp); /* A */
+         VEC4_MUL(source[3], quadColor[3], comp); /* A */
       }
       break;
    case PIPE_BLENDFACTOR_ZERO:
@@ -438,8 +440,8 @@ blend_quad(struct quad_stage *qs, struct quad_header *quad)
    case PIPE_BLENDFACTOR_INV_SRC_ALPHA:
       {
          float inv_alpha[4];
-         VEC4_SUB(inv_alpha, one, quad->outputs.color[3]);
-         VEC4_MUL(source[3], quad->outputs.color[3], inv_alpha); /* A */
+         VEC4_SUB(inv_alpha, one, quadColor[3]);
+         VEC4_MUL(source[3], quadColor[3], inv_alpha); /* A */
       }
       break;
    case PIPE_BLENDFACTOR_INV_DST_COLOR:
@@ -448,7 +450,7 @@ blend_quad(struct quad_stage *qs, struct quad_header *quad)
       {
          float inv_alpha[4];
          VEC4_SUB(inv_alpha, one, dest[3]);
-         VEC4_MUL(source[3], quad->outputs.color[3], inv_alpha); /* A */
+         VEC4_MUL(source[3], quadColor[3], inv_alpha); /* A */
       }
       break;
    case PIPE_BLENDFACTOR_INV_CONST_COLOR:
@@ -458,7 +460,7 @@ blend_quad(struct quad_stage *qs, struct quad_header *quad)
          float inv_comp[4];
          /* A */
          VEC4_SCALAR(inv_comp, 1.0f - softpipe->blend_color.color[3]);
-         VEC4_MUL(source[3], quad->outputs.color[3], inv_comp);
+         VEC4_MUL(source[3], quadColor[3], inv_comp);
       }
       break;
    default:
@@ -474,14 +476,14 @@ blend_quad(struct quad_stage *qs, struct quad_header *quad)
       /* dest = dest * 1   NO-OP, leave dest as-is */
       break;
    case PIPE_BLENDFACTOR_SRC_COLOR:
-      VEC4_MUL(dest[0], dest[0], quad->outputs.color[0]); /* R */
-      VEC4_MUL(dest[1], dest[1], quad->outputs.color[1]); /* G */
-      VEC4_MUL(dest[2], dest[2], quad->outputs.color[2]); /* B */
+      VEC4_MUL(dest[0], dest[0], quadColor[0]); /* R */
+      VEC4_MUL(dest[1], dest[1], quadColor[1]); /* G */
+      VEC4_MUL(dest[2], dest[2], quadColor[2]); /* B */
       break;
    case PIPE_BLENDFACTOR_SRC_ALPHA:
-      VEC4_MUL(dest[0], dest[0], quad->outputs.color[3]); /* R * A */
-      VEC4_MUL(dest[1], dest[1], quad->outputs.color[3]); /* G * A */
-      VEC4_MUL(dest[2], dest[2], quad->outputs.color[3]); /* B * A */
+      VEC4_MUL(dest[0], dest[0], quadColor[3]); /* R * A */
+      VEC4_MUL(dest[1], dest[1], quadColor[3]); /* G * A */
+      VEC4_MUL(dest[2], dest[2], quadColor[3]); /* B * A */
       break;
    case PIPE_BLENDFACTOR_DST_ALPHA:
       VEC4_MUL(dest[0], dest[0], dest[3]); /* R * A */
@@ -529,18 +531,18 @@ blend_quad(struct quad_stage *qs, struct quad_header *quad)
    case PIPE_BLENDFACTOR_INV_SRC_COLOR:
       {
          float inv_comp[4];
-         VEC4_SUB(inv_comp, one, quad->outputs.color[0]); /* R */
+         VEC4_SUB(inv_comp, one, quadColor[0]); /* R */
          VEC4_MUL(dest[0], inv_comp, dest[0]); /* R */
-         VEC4_SUB(inv_comp, one, quad->outputs.color[1]); /* G */
+         VEC4_SUB(inv_comp, one, quadColor[1]); /* G */
          VEC4_MUL(dest[1], inv_comp, dest[1]); /* G */
-         VEC4_SUB(inv_comp, one, quad->outputs.color[2]); /* B */
+         VEC4_SUB(inv_comp, one, quadColor[2]); /* B */
          VEC4_MUL(dest[2], inv_comp, dest[2]); /* B */
       }
       break;
    case PIPE_BLENDFACTOR_INV_SRC_ALPHA:
       {
          float one_minus_alpha[QUAD_SIZE];
-         VEC4_SUB(one_minus_alpha, one, quad->outputs.color[3]);
+         VEC4_SUB(one_minus_alpha, one, quadColor[3]);
          VEC4_MUL(dest[0], dest[0], one_minus_alpha); /* R */
          VEC4_MUL(dest[1], dest[1], one_minus_alpha); /* G */
          VEC4_MUL(dest[2], dest[2], one_minus_alpha); /* B */
@@ -549,7 +551,7 @@ blend_quad(struct quad_stage *qs, struct quad_header *quad)
    case PIPE_BLENDFACTOR_INV_DST_ALPHA:
       {
          float inv_comp[4];
-         VEC4_SUB(inv_comp, one, quad->outputs.color[3]); /* A */
+         VEC4_SUB(inv_comp, one, quadColor[3]); /* A */
          VEC4_MUL(dest[0], inv_comp, dest[0]); /* R */
          VEC4_MUL(dest[1], inv_comp, dest[1]); /* G */
          VEC4_MUL(dest[2], inv_comp, dest[2]); /* B */
@@ -608,7 +610,7 @@ blend_quad(struct quad_stage *qs, struct quad_header *quad)
    case PIPE_BLENDFACTOR_SRC_COLOR:
       /* fall-through */
    case PIPE_BLENDFACTOR_SRC_ALPHA:
-      VEC4_MUL(dest[3], dest[3], quad->outputs.color[3]); /* A * A */
+      VEC4_MUL(dest[3], dest[3], quadColor[3]); /* A * A */
       break;
    case PIPE_BLENDFACTOR_DST_COLOR:
       /* fall-through */
@@ -635,7 +637,7 @@ blend_quad(struct quad_stage *qs, struct quad_header *quad)
    case PIPE_BLENDFACTOR_INV_SRC_ALPHA:
       {
          float one_minus_alpha[QUAD_SIZE];
-         VEC4_SUB(one_minus_alpha, one, quad->outputs.color[3]);
+         VEC4_SUB(one_minus_alpha, one, quadColor[3]);
          VEC4_MUL(dest[3], dest[3], one_minus_alpha); /* A */
       }
       break;
@@ -666,29 +668,29 @@ blend_quad(struct quad_stage *qs, struct quad_header *quad)
     */
    switch (softpipe->blend->rgb_func) {
    case PIPE_BLEND_ADD:
-      VEC4_ADD(quad->outputs.color[0], source[0], dest[0]); /* R */
-      VEC4_ADD(quad->outputs.color[1], source[1], dest[1]); /* G */
-      VEC4_ADD(quad->outputs.color[2], source[2], dest[2]); /* B */
+      VEC4_ADD(quadColor[0], source[0], dest[0]); /* R */
+      VEC4_ADD(quadColor[1], source[1], dest[1]); /* G */
+      VEC4_ADD(quadColor[2], source[2], dest[2]); /* B */
       break;
    case PIPE_BLEND_SUBTRACT:
-      VEC4_SUB(quad->outputs.color[0], source[0], dest[0]); /* R */
-      VEC4_SUB(quad->outputs.color[1], source[1], dest[1]); /* G */
-      VEC4_SUB(quad->outputs.color[2], source[2], dest[2]); /* B */
+      VEC4_SUB(quadColor[0], source[0], dest[0]); /* R */
+      VEC4_SUB(quadColor[1], source[1], dest[1]); /* G */
+      VEC4_SUB(quadColor[2], source[2], dest[2]); /* B */
       break;
    case PIPE_BLEND_REVERSE_SUBTRACT:
-      VEC4_SUB(quad->outputs.color[0], dest[0], source[0]); /* R */
-      VEC4_SUB(quad->outputs.color[1], dest[1], source[1]); /* G */
-      VEC4_SUB(quad->outputs.color[2], dest[2], source[2]); /* B */
+      VEC4_SUB(quadColor[0], dest[0], source[0]); /* R */
+      VEC4_SUB(quadColor[1], dest[1], source[1]); /* G */
+      VEC4_SUB(quadColor[2], dest[2], source[2]); /* B */
       break;
    case PIPE_BLEND_MIN:
-      VEC4_MIN(quad->outputs.color[0], source[0], dest[0]); /* R */
-      VEC4_MIN(quad->outputs.color[1], source[1], dest[1]); /* G */
-      VEC4_MIN(quad->outputs.color[2], source[2], dest[2]); /* B */
+      VEC4_MIN(quadColor[0], source[0], dest[0]); /* R */
+      VEC4_MIN(quadColor[1], source[1], dest[1]); /* G */
+      VEC4_MIN(quadColor[2], source[2], dest[2]); /* B */
       break;
    case PIPE_BLEND_MAX:
-      VEC4_MAX(quad->outputs.color[0], source[0], dest[0]); /* R */
-      VEC4_MAX(quad->outputs.color[1], source[1], dest[1]); /* G */
-      VEC4_MAX(quad->outputs.color[2], source[2], dest[2]); /* B */
+      VEC4_MAX(quadColor[0], source[0], dest[0]); /* R */
+      VEC4_MAX(quadColor[1], source[1], dest[1]); /* G */
+      VEC4_MAX(quadColor[2], source[2], dest[2]); /* B */
       break;
    default:
       assert(0);
@@ -699,19 +701,19 @@ blend_quad(struct quad_stage *qs, struct quad_header *quad)
     */
    switch (softpipe->blend->alpha_func) {
    case PIPE_BLEND_ADD:
-      VEC4_ADD(quad->outputs.color[3], source[3], dest[3]); /* A */
+      VEC4_ADD(quadColor[3], source[3], dest[3]); /* A */
       break;
    case PIPE_BLEND_SUBTRACT:
-      VEC4_SUB(quad->outputs.color[3], source[3], dest[3]); /* A */
+      VEC4_SUB(quadColor[3], source[3], dest[3]); /* A */
       break;
    case PIPE_BLEND_REVERSE_SUBTRACT:
-      VEC4_SUB(quad->outputs.color[3], dest[3], source[3]); /* A */
+      VEC4_SUB(quadColor[3], dest[3], source[3]); /* A */
       break;
    case PIPE_BLEND_MIN:
-      VEC4_MIN(quad->outputs.color[3], source[3], dest[3]); /* A */
+      VEC4_MIN(quadColor[3], source[3], dest[3]); /* A */
       break;
    case PIPE_BLEND_MAX:
-      VEC4_MAX(quad->outputs.color[3], source[3], dest[3]); /* A */
+      VEC4_MAX(quadColor[3], source[3], dest[3]); /* A */
       break;
    default:
       abort();
diff --git a/src/mesa/pipe/softpipe/sp_quad_colormask.c b/src/mesa/pipe/softpipe/sp_quad_colormask.c
index f5e0a32d1b..867cc0725a 100644
--- a/src/mesa/pipe/softpipe/sp_quad_colormask.c
+++ b/src/mesa/pipe/softpipe/sp_quad_colormask.c
@@ -52,6 +52,7 @@ colormask_quad(struct quad_stage *qs, struct quad_header *quad)
       = sp_get_cached_tile(softpipe,
                            softpipe->cbuf_cache[softpipe->current_cbuf],
                            quad->x0, quad->y0);
+   float (*quadColor)[4] = quad->outputs.color;
    uint i, j;
 
    /* get/swizzle dest colors */
@@ -65,19 +66,19 @@ colormask_quad(struct quad_stage *qs, struct quad_header *quad)
 
    /* R */
    if (!(softpipe->blend->colormask & PIPE_MASK_R))
-       COPY_4V(quad->outputs.color[0], dest[0]);
+       COPY_4V(quadColor[0], dest[0]);
 
    /* G */
    if (!(softpipe->blend->colormask & PIPE_MASK_G))
-       COPY_4V(quad->outputs.color[1], dest[1]);
+       COPY_4V(quadColor[1], dest[1]);
 
    /* B */
    if (!(softpipe->blend->colormask & PIPE_MASK_B))
-       COPY_4V(quad->outputs.color[2], dest[2]);
+       COPY_4V(quadColor[2], dest[2]);
 
    /* A */
    if (!(softpipe->blend->colormask & PIPE_MASK_A))
-       COPY_4V(quad->outputs.color[3], dest[3]);
+       COPY_4V(quadColor[3], dest[3]);
 
    /* pass quad to next stage */
    qs->next->run(qs->next, quad);
diff --git a/src/mesa/pipe/softpipe/sp_quad_coverage.c b/src/mesa/pipe/softpipe/sp_quad_coverage.c
index 9dfad7c580..cca2b9f79b 100644
--- a/src/mesa/pipe/softpipe/sp_quad_coverage.c
+++ b/src/mesa/pipe/softpipe/sp_quad_coverage.c
@@ -50,11 +50,12 @@ coverage_quad(struct quad_stage *qs, struct quad_header *quad)
    if ((softpipe->rasterizer->poly_smooth && quad->prim == PRIM_TRI) ||
        (softpipe->rasterizer->line_smooth && quad->prim == PRIM_LINE) ||
        (softpipe->rasterizer->point_smooth && quad->prim == PRIM_POINT)) {
+      float (*quadColor)[4] = quad->outputs.color;
       unsigned j;
       for (j = 0; j < QUAD_SIZE; j++) {
          assert(quad->coverage[j] >= 0.0);
          assert(quad->coverage[j] <= 1.0);
-         quad->outputs.color[3][j] *= quad->coverage[j];
+         quadColor[3][j] *= quad->coverage[j];
       }
    }
 
diff --git a/src/mesa/pipe/softpipe/sp_quad_output.c b/src/mesa/pipe/softpipe/sp_quad_output.c
index f04a550e3d..bfd7baa946 100644
--- a/src/mesa/pipe/softpipe/sp_quad_output.c
+++ b/src/mesa/pipe/softpipe/sp_quad_output.c
@@ -49,6 +49,7 @@ output_quad(struct quad_stage *qs, struct quad_header *quad)
    /* in-tile pos: */
    const int itx = quad->x0 % TILE_SIZE;
    const int ity = quad->y0 % TILE_SIZE;
+   float (*quadColor)[4] = quad->outputs.color;
    int i, j;
 
    /* get/swizzle dest colors */
@@ -57,7 +58,7 @@ output_quad(struct quad_stage *qs, struct quad_header *quad)
          int x = itx + (j & 1);
          int y = ity + (j >> 1);
          for (i = 0; i < 4; i++) { /* loop over color chans */
-            tile->data.color[y][x][i] = quad->outputs.color[i][j];
+            tile->data.color[y][x][i] = quadColor[i][j];
          }
       }
    }
-- 
cgit v1.2.3