summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorcmcnulty <cmcnulty@kznf.com>2013-10-23 15:09:42 -0500
committercmcnulty <cmcnulty@kznf.com>2013-10-23 15:09:42 -0500
commit52616821c89d6e3b6c90288bb642c7efc7af9bd7 (patch)
treee437597d80cbe5da300e6ef4040664b79b0c6442
parent6abdfff07ddaf375bac51f74b5be4435f2878121 (diff)
#1489392 - arrow key with control down should *not* select messages
In alignment with desktop applications (windows & mac) using the arrow keys with the control key pressed should not select the messages. Changes code so that with_mouse will be passed as true when click event occurs, and row will only be toggled if it was a click event.
-rw-r--r--program/js/list.js11
1 files changed, 5 insertions, 6 deletions
diff --git a/program/js/list.js b/program/js/list.js
index cb69bc462..33f88ab10 100644
--- a/program/js/list.js
+++ b/program/js/list.js
@@ -456,12 +456,11 @@ click_row: function(e, id)
var dblclicked = now - this.rows[id].clicked < this.dblclick_time;
- // unselects currently selected row
- if (!this.drag_active && this.in_selection_before == id && !dblclicked)
- this.select_row(id, mod_key, false);
-
+ // selects/unselects currently selected row
+ if (!this.drag_active && !dblclicked)
+ this.select_row(id, mod_key, true);
+
this.drag_start = false;
- this.in_selection_before = false;
// row was double clicked
if (this.rowcount && dblclicked && this.in_selection(id)) {
@@ -787,7 +786,7 @@ select_row: function(id, mod_key, with_mouse)
break;
case CONTROL_KEY:
- if (!with_mouse)
+ if (with_mouse)
this.highlight_row(id, true);
break;