diff options
author | alecpl <alec@alec.pl> | 2011-08-26 09:22:53 +0000 |
---|---|---|
committer | alecpl <alec@alec.pl> | 2011-08-26 09:22:53 +0000 |
commit | a98ee35134d7cbe112c6074d48a2a22e506ef2f3 (patch) | |
tree | 26b2db7d703815d15819ea2ac0b89d98e5375d60 | |
parent | da71783bc95f786968955a865943f6052eca83a4 (diff) |
- Microoptimization: use substr_replace() for injecting a string into string
-rw-r--r-- | program/include/rcube_html_page.php | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/program/include/rcube_html_page.php b/program/include/rcube_html_page.php index 200233c5d..21301e331 100644 --- a/program/include/rcube_html_page.php +++ b/program/include/rcube_html_page.php @@ -212,7 +212,7 @@ class rcube_html_page if (!empty($this->scripts['docready'])) { $this->add_script('$(document).ready(function(){ ' . $this->scripts['docready'] . "\n});", 'foot'); } - + if (is_array($this->script_files['foot'])) { foreach ($this->script_files['foot'] as $file) { $page_footer .= sprintf($this->script_tag_file, $file); @@ -246,7 +246,7 @@ class rcube_html_page // add page hader if ($hpos) { - $output = substr($output,0,$hpos) . $page_header . substr($output,$hpos,strlen($output)); + $output = substr_replace($output, $page_header, $hpos, 0); } else { $output = $page_header . $output; @@ -254,7 +254,7 @@ class rcube_html_page // add page footer if (($fpos = strripos($output, '</body>')) || ($fpos = strripos($output, '</html>'))) { - $output = substr($output, 0, $fpos) . "$page_footer\n" . substr($output, $fpos); + $output = substr_replace($output, $page_footer."\n", $fpos, 0); } else { $output .= "\n".$page_footer; @@ -268,7 +268,7 @@ class rcube_html_page foreach ($this->css_files as $file) { $css .= sprintf($this->link_css_file, $file); } - $output = substr($output, 0, $pos) . $css . substr($output, $pos); + $output = substr_replace($output, $css, $pos, 0); } $this->base_path = $base_path; @@ -289,7 +289,7 @@ class rcube_html_page echo $hook['content']; } } - + /** * Callback function for preg_replace_callback in write() * |