summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAleksander Machniak <alec@alec.pl>2013-06-26 09:05:47 +0200
committerAleksander Machniak <alec@alec.pl>2013-06-26 09:06:32 +0200
commitdaa131395e25765b2cd0c31302e0fa9021528b9e (patch)
treedbed6ae6b9049cdae8cc9edacba56acb2ba85606
parent2f98161392a160a3d5eb1a337789ad8586aaaf71 (diff)
Remove deprecated (in PHP 5.5) PREG /e modifier usage (#1489174)
-rw-r--r--CHANGELOG1
-rw-r--r--installer/rcube_install.php6
2 files changed, 5 insertions, 2 deletions
diff --git a/CHANGELOG b/CHANGELOG
index 828bbf259..c411bee71 100644
--- a/CHANGELOG
+++ b/CHANGELOG
@@ -1,6 +1,7 @@
CHANGELOG Roundcube Webmail
===========================
+- Remove deprecated (in PHP 5.5) PREG /e modifier usage (#1489174)
- Fix empty messages list when register_globals is enabled (#1489157)
- Fix so valid and set date.timezone is not required by installer checks (#1489180)
- Canonize boolean ini_get() results (#1489189)
diff --git a/installer/rcube_install.php b/installer/rcube_install.php
index 43e6407a3..bbb519d5c 100644
--- a/installer/rcube_install.php
+++ b/installer/rcube_install.php
@@ -217,10 +217,12 @@ class rcube_install
// save change
$this->config[$prop] = $value;
+ $dump = self::_dump_var($value, $prop);
+
// replace the matching line in config file
$out = preg_replace(
- '/(\$rcmail_config\[\''.preg_quote($prop).'\'\])\s+=\s+(.+);/Uie',
- "'\\1 = ' . rcube_install::_dump_var(\$value, \$prop) . ';'",
+ '/(\$rcmail_config\[\''.preg_quote($prop).'\'\])\s+=\s+(.+);/Ui',
+ "\\1 = $dump;",
$out);
}