summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authoralecpl <alec@alec.pl>2011-10-03 17:52:35 +0000
committeralecpl <alec@alec.pl>2011-10-03 17:52:35 +0000
commit03079a5a51adb2020fadd9fc2d7bf54049f82f43 (patch)
treeb78cf15c4f9cd70a2aac1f0b9d20dcc30fd94a63
parent765fdeb5b5269f7647972046bac3d0054a6b7946 (diff)
- Fix: skip redundant cache queries when an entry doesn't exist
-rw-r--r--program/include/rcube_cache.php39
1 files changed, 23 insertions, 16 deletions
diff --git a/program/include/rcube_cache.php b/program/include/rcube_cache.php
index ee9439101..69f5b3176 100644
--- a/program/include/rcube_cache.php
+++ b/program/include/rcube_cache.php
@@ -245,26 +245,30 @@ class rcube_cache
return null;
}
- if ($this->type == 'memcache') {
- $data = $this->db->get($this->ckey($key));
- }
- else if ($this->type == 'apc') {
- $data = apc_fetch($this->ckey($key));
- }
+ if ($this->type != 'db') {
+ if ($this->type == 'memcache') {
+ $data = $this->db->get($this->ckey($key));
+ }
+ else if ($this->type == 'apc') {
+ $data = apc_fetch($this->ckey($key));
+ }
- if ($data) {
- $md5sum = md5($data);
- $data = $this->packed ? unserialize($data) : $data;
+ if ($data) {
+ $md5sum = md5($data);
+ $data = $this->packed ? unserialize($data) : $data;
- if ($nostore) {
- return $data;
- }
+ if ($nostore) {
+ return $data;
+ }
- $this->cache_sums[$key] = $md5sum;
- $this->cache[$key] = $data;
+ $this->cache_sums[$key] = $md5sum;
+ $this->cache[$key] = $data;
+ }
+ else if (!$nostore) {
+ $this->cache[$key] = null;
+ }
}
-
- if ($this->type == 'db') {
+ else {
$sql_result = $this->db->limitquery(
"SELECT cache_id, data, cache_key".
" FROM ".get_table_name('cache').
@@ -290,6 +294,9 @@ class rcube_cache
$this->cache_sums[$key] = $md5sum;
$this->cache_keys[$key] = $sql_arr['cache_id'];
}
+ else if (!$nostore) {
+ $this->cache[$key] = null;
+ }
}
return $this->cache[$key];