diff options
| author | Thomas Bruederli <thomas@roundcube.net> | 2013-07-09 17:02:51 +0200 |
|---|---|---|
| committer | Thomas Bruederli <thomas@roundcube.net> | 2013-07-09 17:02:51 +0200 |
| commit | d8e10161098db2dcd03390bc7169cd88b31d4c60 (patch) | |
| tree | b4e245bf64cc34c0ba970deb9b5baa5e786e2cda | |
| parent | d3d1e38d7266106baf2bf2256a568691f3e55220 (diff) | |
Fix opening in new window; keep extwin mode when switching help actions
| -rw-r--r-- | plugins/help/help.js | 2 | ||||
| -rw-r--r-- | plugins/help/help.php | 9 | ||||
| -rw-r--r-- | plugins/help/skins/classic/help.css | 14 | ||||
| -rw-r--r-- | plugins/help/skins/classic/templates/help.html | 15 | ||||
| -rw-r--r-- | plugins/help/skins/larry/templates/help.html | 6 |
5 files changed, 37 insertions, 9 deletions
diff --git a/plugins/help/help.js b/plugins/help/help.js index e53e96755..59a93c537 100644 --- a/plugins/help/help.js +++ b/plugins/help/help.js @@ -13,7 +13,7 @@ if (window.rcmail) { var url = rcmail.url('help/index', { _rel: rcmail.task + (rcmail.env.action ? '/'+rcmail.env.action : '') }); if (rcmail.env.help_open_extwin) { - rcmail.open_window(url, true, false); + rcmail.open_window(url, 1020, false); } else { rcmail.redirect(url, false); diff --git a/plugins/help/help.php b/plugins/help/help.php index ab665d0a8..37fd908a3 100644 --- a/plugins/help/help.php +++ b/plugins/help/help.php @@ -61,6 +61,7 @@ class help extends rcube_plugin // register UI objects $rcmail->output->add_handlers(array( 'helpcontent' => array($this, 'content'), + 'tablink' => array($this, 'tablink'), )); if ($rcmail->action == 'about') @@ -73,6 +74,14 @@ class help extends rcube_plugin $rcmail->output->send('help.help'); } + function tablink($attrib) + { + $rcmail = rcmail::get_instance(); + $attrib['name'] = 'helplink' . $attrib['action']; + $attrib['href'] = $rcmail->url(array('_action' => $attrib['action'], '_extwin' => !empty($_REQUEST['_extwin']) ? 1 : null)); + return $rcmail->output->button($attrib); + } + function content($attrib) { $rcmail = rcmail::get_instance(); diff --git a/plugins/help/skins/classic/help.css b/plugins/help/skins/classic/help.css index ad5b7dab4..c45b8f0b0 100644 --- a/plugins/help/skins/classic/help.css +++ b/plugins/help/skins/classic/help.css @@ -5,6 +5,20 @@ background-image: url('help.gif'); } +.extwin #tabsbar +{ + top: 21px; + left: 20px; + right: 100px; + border-bottom: 0; +} + +.closelink { + position: absolute; + top: 20px; + right: 20px; +} + .help-box { overflow: auto; diff --git a/plugins/help/skins/classic/templates/help.html b/plugins/help/skins/classic/templates/help.html index 5bc342044..3d5b22869 100644 --- a/plugins/help/skins/classic/templates/help.html +++ b/plugins/help/skins/classic/templates/help.html @@ -15,15 +15,20 @@ function help_init_settings_tabs() } </script> </head> -<roundcube:if condition="env:extwin" /><body class="extwin"><roundcube:else /><body><roundcube:endif /> - +<roundcube:if condition="env:extwin" /> +<body class="extwin"> +<roundcube:object name="message" id="message" /> +<roundcube:button name="close" type="link" label="close" class="closelink" onclick="self.close()" /> +<roundcube:else /> +<body> <roundcube:include file="/includes/taskbar.html" /> <roundcube:include file="/includes/header.html" /> +<roundcube:endif /> <div id="tabsbar"> -<span id="helptabindex" class="tablink"><roundcube:button name="helpindex" href="?_task=help" type="link" label="help.help" title="help.help" /></span> -<span id="helptababout" class="tablink"><roundcube:button name="helpabout" href="?_task=help&_action=about" type="link" label="help.about" title="help.about" class="tablink" /></span> -<span id="helptablicense" class="tablink"><roundcube:button name="helplicense" href="?_task=help&_action=license" type="link" label="help.license" title="help.license" class="tablink" /></span> +<span id="helptabindex" class="tablink"><roundcube:object name="tablink" action="index" type="link" label="help.help" title="help.help" /></span> +<span id="helptababout" class="tablink"><roundcube:object name="tablink" action="about" type="link" label="help.about" title="help.about" class="tablink" /></span> +<span id="helptablicense" class="tablink"><roundcube:object name="tablink" action="license" type="link" label="help.license" title="help.license" class="tablink" /></span> <roundcube:container name="helptabs" id="helptabsbar" /> <script type="text/javascript"> if (window.rcmail) rcmail.add_onload(help_init_settings_tabs);</script> </div> diff --git a/plugins/help/skins/larry/templates/help.html b/plugins/help/skins/larry/templates/help.html index 592a94c66..bfd3f1141 100644 --- a/plugins/help/skins/larry/templates/help.html +++ b/plugins/help/skins/larry/templates/help.html @@ -11,9 +11,9 @@ <div id="mainscreen"> <div id="helptoolbar" class="toolbar"> -<roundcube:button name="helpdefault" href="?_task=help" type="link" label="help.help" title="help.help" class="button help" /> -<roundcube:button name="helpabout" href="?_task=help&_action=about" type="link" label="help.about" title="help.about" class="button about" /> -<roundcube:button name="helplicense" href="?_task=help&_action=license" type="link" label="help.license" title="help.license" class="button license" /> +<roundcube:object name="tablink" action="index" type="link" label="help.help" title="help.help" class="button help" /> +<roundcube:object name="tablink" action="about" type="link" label="help.about" title="help.about" class="button about" /> +<roundcube:object name="tablink" action="license" type="link" label="help.license" title="help.license" class="button license" /> <roundcube:container name="helptabs" id="helptabsbar" /> </div> |