summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGiovanni Bajo <rasky@develer.com>2012-05-12 18:16:19 +0200
committerGiovanni Bajo <rasky@develer.com>2012-05-12 18:16:19 +0200
commit14f22f38da9eff3dd8634d288913081d2d2e7b16 (patch)
tree02be63560ac5a493eb8d5c993e8d4d6bb573a51c
parent1c9e571602e493e03e061bd1d659ee628b247e93 (diff)
Fix support for large uuencode attachments.
Currently, Roundcube tries to match with a regexp a whole uuencode attachment. This is not always possible because PHP enforces a limit on the maximum match size.
-rw-r--r--program/include/rcube_message.php17
1 files changed, 13 insertions, 4 deletions
diff --git a/program/include/rcube_message.php b/program/include/rcube_message.php
index dafbe3201..5579c2ce0 100644
--- a/program/include/rcube_message.php
+++ b/program/include/rcube_message.php
@@ -655,23 +655,29 @@ class rcube_message
$parts = array();
// FIXME: line length is max.65?
- $uu_regexp = '/begin [0-7]{3,4} ([^\n]+)\n(([\x21-\x7E]{0,65}\n)+)`\nend/s';
+ $uu_regexp = '/begin [0-7]{3,4} ([^\n]+)\n/s';
if (preg_match_all($uu_regexp, $part->body, $matches, PREG_SET_ORDER)) {
- // remove attachments bodies from the message body
- $part->body = preg_replace($uu_regexp, '', $part->body);
// update message content-type
$part->ctype_primary = 'multipart';
$part->ctype_secondary = 'mixed';
$part->mimetype = $part->ctype_primary . '/' . $part->ctype_secondary;
+ $uu_endstring = "`\nend\n";
// add attachments to the structure
foreach ($matches as $pid => $att) {
+ $startpos = strpos($part->body, $att[1]) + strlen($att[1]) + 1; // "\n"
+ $endpos = strpos($part->body, $uu_endstring);
+ $filebody = substr($part->body, $startpos, $endpos-$startpos);
+
+ // remove attachments bodies from the message body
+ $part->body = substr_replace($part->body, "", $startpos, $endpos+strlen($uu_endstring)-$startpos);
+
$uupart = new rcube_message_part;
$uupart->filename = trim($att[1]);
$uupart->encoding = 'stream';
- $uupart->body = convert_uudecode($att[2]);
+ $uupart->body = convert_uudecode($filebody);
$uupart->size = strlen($uupart->body);
$uupart->mime_id = 'uu.' . $part->mime_id . '.' . $pid;
@@ -682,6 +688,9 @@ class rcube_message
$parts[] = $uupart;
unset($matches[$pid]);
}
+
+ // remove attachments bodies from the message body
+ $part->body = preg_replace($uu_regexp, '', $part->body);
}
return $parts;