summaryrefslogtreecommitdiff
path: root/installer/rcube_install.php
diff options
context:
space:
mode:
authorAleksander Machniak <alec@alec.pl>2013-04-26 11:26:58 +0200
committerAleksander Machniak <alec@alec.pl>2013-04-26 11:26:58 +0200
commitf23ef1c96859f6b01a9268c8606a22ceb719cf3d (patch)
tree7c4ea8f0c79caba006903cffdbeddb31c9154f38 /installer/rcube_install.php
parentddfdd8938d78b40842a984d310e3c35af30ece0a (diff)
Fix error handling in CLI mode, use STDERR and non-empty exit code (#1489043)
Diffstat (limited to 'installer/rcube_install.php')
-rw-r--r--installer/rcube_install.php6
1 files changed, 4 insertions, 2 deletions
diff --git a/installer/rcube_install.php b/installer/rcube_install.php
index b86ccab02..2e1298707 100644
--- a/installer/rcube_install.php
+++ b/installer/rcube_install.php
@@ -637,8 +637,10 @@ class rcube_install
*/
function update_db($version)
{
- system(INSTALL_PATH . "bin/updatedb.sh --package=roundcube --version=" . $version
- . " --dir=" . INSTALL_PATH . "SQL", $result);
+ system(INSTALL_PATH . "bin/updatedb.sh --package=roundcube"
+ . " --version=" . escapeshellarg($version)
+ . " --dir=" . INSTALL_PATH . "SQL"
+ . " 2>&1", $result);
return !$result;
}