diff options
author | Aleksander Machniak <alec@alec.pl> | 2013-05-07 15:12:22 +0200 |
---|---|---|
committer | Aleksander Machniak <alec@alec.pl> | 2013-05-07 15:12:22 +0200 |
commit | 3725cfb245bfae3a77baf857ea5403e8064b84b9 (patch) | |
tree | 91a918c017e5c351d6175e9c416c702b08007dac /installer | |
parent | 2193f6a1301edcb62de6f0cf338acccdbf5ec2f1 (diff) |
Avoid uninitialized/unused variables
Diffstat (limited to 'installer')
-rw-r--r-- | installer/rcube_install.php | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/installer/rcube_install.php b/installer/rcube_install.php index 32b6a5dd7..e7da54c2c 100644 --- a/installer/rcube_install.php +++ b/installer/rcube_install.php @@ -347,7 +347,7 @@ class rcube_install $this->config = array_merge($this->config, $current); - foreach ((array)$current['ldap_public'] as $key => $values) { + foreach (array_keys((array)$current['ldap_public']) as $key) { $this->config['ldap_public'][$key] = $current['ldap_public'][$key]; } } @@ -356,10 +356,11 @@ class rcube_install * Compare the local database schema with the reference schema * required for this version of Roundcube * - * @param boolean True if the schema schould be updated + * @param rcube_db Database object + * * @return boolean True if the schema is up-to-date, false if not or an error occured */ - function db_schema_check($DB, $update = false) + function db_schema_check($DB) { if (!$this->configured) return false; @@ -583,7 +584,7 @@ class rcube_install } else { // check if all keys are numeric $isnum = true; - foreach ($var as $key => $value) { + foreach (array_keys($var) as $key) { if (!is_numeric($key)) { $isnum = false; break; |