diff options
author | Aleksander Machniak <alec@alec.pl> | 2012-06-26 11:11:53 +0200 |
---|---|---|
committer | Aleksander Machniak <alec@alec.pl> | 2012-06-26 11:11:53 +0200 |
commit | 7ab9c1775243217f3f6cb0717b1894a98303d04e (patch) | |
tree | 26dfb5b697344bcfa3bc97ba7e793bf26087ba7c /program/include/rcube_imap_generic.php | |
parent | d86aa138d09c772f9506bf3c0ca2c65a8f33bdfa (diff) |
Improve performance by skipping redundant ENABLE commands
Diffstat (limited to 'program/include/rcube_imap_generic.php')
-rw-r--r-- | program/include/rcube_imap_generic.php | 27 |
1 files changed, 23 insertions, 4 deletions
diff --git a/program/include/rcube_imap_generic.php b/program/include/rcube_imap_generic.php index 959dd9fd0..197164dfe 100644 --- a/program/include/rcube_imap_generic.php +++ b/program/include/rcube_imap_generic.php @@ -1472,14 +1472,31 @@ class rcube_imap_generic */ function enable($extension) { - if (empty($extension)) + if (empty($extension)) { return false; + } - if (!$this->hasCapability('ENABLE')) + if (!$this->hasCapability('ENABLE')) { return false; + } - if (!is_array($extension)) + if (!is_array($extension)) { $extension = array($extension); + } + + if (!empty($this->extensions_enabled)) { + // check if all extensions are already enabled + $diff = array_diff($extension, $this->extensions_enabled); + + if (empty($diff)) { + return $extension; + } + + // Make sure the mailbox isn't selected, before enabling extension(s) + if ($this->selected !== null) { + $this->close(); + } + } list($code, $response) = $this->execute('ENABLE', $extension); @@ -1487,7 +1504,9 @@ class rcube_imap_generic $response = substr($response, 10); // remove prefix "* ENABLED " $result = (array) $this->tokenizeResponse($response); - return $result; + $this->extensions_enabled = array_unique(array_merge((array)$this->extensions_enabled, $result)); + + return $this->extensions_enabled; } return false; |