summaryrefslogtreecommitdiff
path: root/program/steps
diff options
context:
space:
mode:
authorthomascube <thomas@roundcube.net>2008-07-29 12:32:19 +0000
committerthomascube <thomas@roundcube.net>2008-07-29 12:32:19 +0000
commitf92aba3918575f30f577542753a2912df5729374 (patch)
treed14e1c6b27bfa7219a906be7a8fd9540daa7aae0 /program/steps
parent8c72e33d3764cf2695256ab9c2a490d4c4f53696 (diff)
Add microformats to address book + fix html output + codestyle
Diffstat (limited to 'program/steps')
-rw-r--r--program/steps/addressbook/edit.inc2
-rw-r--r--program/steps/addressbook/show.inc54
2 files changed, 29 insertions, 27 deletions
diff --git a/program/steps/addressbook/edit.inc b/program/steps/addressbook/edit.inc
index 71983fce6..61c660d94 100644
--- a/program/steps/addressbook/edit.inc
+++ b/program/steps/addressbook/edit.inc
@@ -90,7 +90,7 @@ function get_form_tags($attrib)
if (!strlen($EDIT_FORM))
{
$hiddenfields = new html_hiddenfield(array('name' => '_task', 'value' => $RCMAIL->task));
- $hiddenfields->add(array('name' => '_action', 'value' => 'save', 'source' => get_input_value('_source', RCUBE_INPUT_GPC)));
+ $hiddenfields->add(array('name' => '_action', 'value' => 'save'));
$hiddenfields->add(array('name' => '_source', 'value' => get_input_value('_source', RCUBE_INPUT_GPC)));
$hiddenfields->add(array('name' => '_framed', 'value' => (empty($_REQUEST['_framed']) ? 0 : 1)));
diff --git a/program/steps/addressbook/show.inc b/program/steps/addressbook/show.inc
index 75f1e7452..96ee5bb55 100644
--- a/program/steps/addressbook/show.inc
+++ b/program/steps/addressbook/show.inc
@@ -5,7 +5,7 @@
| program/steps/addressbook/show.inc |
| |
| This file is part of the RoundCube Webmail client |
- | Copyright (C) 2005-2007, RoundCube Dev. - Switzerland |
+ | Copyright (C) 2005-2008, RoundCube Dev. - Switzerland |
| Licensed under the GNU GPL |
| |
| PURPOSE: |
@@ -21,50 +21,52 @@
// read contact record
-if (($cid = get_input_value('_cid', RCUBE_INPUT_GPC)) && ($record = $CONTACTS->get_record($cid, true)))
+if (($cid = get_input_value('_cid', RCUBE_INPUT_GPC)) && ($record = $CONTACTS->get_record($cid, true))) {
$OUTPUT->set_env('cid', $record['ID']);
-
+}
function rcmail_contact_details($attrib)
- {
+{
global $CONTACTS, $OUTPUT;
// check if we have a valid result
- if (!(($result = $CONTACTS->get_result()) && ($record = $result->first())))
- {
+ if (!(($result = $CONTACTS->get_result()) && ($record = $result->first()))) {
$OUTPUT->show_message('contactnotfound');
return false;
}
// a specific part is requested
- if ($attrib['part'])
+ if ($attrib['part']) {
return Q($record[$attrib['part']]);
+ }
// return the complete address record as table
- $out = "<table>\n\n";
+ $table = new html_table(array('cols' => 2));
$a_show_cols = array('name', 'firstname', 'surname', 'email');
- foreach ($a_show_cols as $col)
- {
- if ($col=='email' && !empty($record[$col]))
- $value = sprintf(
- '<a href="#compose" onclick="%s.command(\'compose\', \'%s\')" title="%s">%s</a>',
- JS_OBJECT_NAME,
- JQ($record[$col]),
- rcube_label('composeto'),
- Q($record[$col]));
+ $microformats = array('name' => 'fn', 'email' => 'email');
+
+ foreach ($a_show_cols as $col) {
+ if ($col == 'email' && !empty($record[$col])) {
+ $value = html::a(array(
+ 'href' => 'mailto:' . $record[$col],
+ 'onclick' => sprintf("return %s.command('compose','%s',this)", JS_OBJECT_NAME, JQ($record[$col])),
+ 'title' => rcube_label('composeto'),
+ 'class' => $microformats[$col],
+ ), Q($record[$col]));
+ }
+ else if (!empty($record[$col])) {
+ $value = html::span($microformats[$col], Q($record[$col]));
+ }
else
- $value = Q($record[$col]);
+ $value = '';
- $out .= sprintf("<tr><td class=\"title\">%s</td><td>%s</td></tr>\n",
- Q(rcube_label($col)),
- $value);
- }
-
- $out .= "\n</table>";
-
- return $out;
+ $table->add('title', Q(rcube_label($col)));
+ $table->add(null, $value);
}
+
+ return $table->show($attrib + array('class' => 'vcard'));
+}
//$OUTPUT->framed = $_framed;