diff options
| author | Aleksander Machniak <alec@alec.pl> | 2013-09-27 14:42:46 +0200 |
|---|---|---|
| committer | Aleksander Machniak <alec@alec.pl> | 2013-09-27 14:42:46 +0200 |
| commit | 170702fd136a877078705f24941893f686a835ce (patch) | |
| tree | 3ae754477ffb0ca50ad821e91bee3d1d2afedc89 /program | |
| parent | 99de1fdd26994715f3e08e00d3f2fc26e7799e4c (diff) | |
We've encountered (malformed) messages with more than
one text/plain or text/html part here. There's no way to choose
which one is better, so we'll display first of them and add
others as attachments (#1489358)
Diffstat (limited to 'program')
| -rw-r--r-- | program/lib/Roundcube/rcube_message.php | 22 |
1 files changed, 12 insertions, 10 deletions
diff --git a/program/lib/Roundcube/rcube_message.php b/program/lib/Roundcube/rcube_message.php index 0d33ea44d..0cc0766f5 100644 --- a/program/lib/Roundcube/rcube_message.php +++ b/program/lib/Roundcube/rcube_message.php @@ -435,17 +435,24 @@ class rcube_message continue; } + // We've encountered (malformed) messages with more than + // one text/plain or text/html part here. There's no way to choose + // which one is better, so we'll display first of them and add + // others as attachments (#1489358) + // check if sub part is if ($is_multipart) $related_part = $p; - else if ($sub_mimetype == 'text/plain') + else if ($sub_mimetype == 'text/plain' && !$plain_part) $plain_part = $p; - else if ($sub_mimetype == 'text/html') + else if ($sub_mimetype == 'text/html' && !$html_part) $html_part = $p; - else if ($sub_mimetype == 'text/enriched') + else if ($sub_mimetype == 'text/enriched' && !$enriched_part) $enriched_part = $p; - else - $attach_part = $p; + else { + // add unsupported/unrecognized parts to attachments list + $this->attachments[] = $sub_part; + } } // parse related part (alternative part could be in here) @@ -486,11 +493,6 @@ class rcube_message $this->parts[] = $c; } - - // add unsupported/unrecognized parts to attachments list - if ($attach_part) { - $this->attachments[] = $structure->parts[$attach_part]; - } } // this is an ecrypted message -> create a plaintext body with the according message else if ($mimetype == 'multipart/encrypted') { |