summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
-rw-r--r--CHANGELOG1
-rw-r--r--program/steps/mail/compose.inc19
2 files changed, 10 insertions, 10 deletions
diff --git a/CHANGELOG b/CHANGELOG
index 6bf79cd98..a120ae0be 100644
--- a/CHANGELOG
+++ b/CHANGELOG
@@ -10,6 +10,7 @@ CHANGELOG Roundcube Webmail
- Use custom sorting when SORT is disabled by IMAP admin (#1486959)
- Allow setting some washtml options from plugin (#1486578)
- Add option do bind for an individual LDAP address book (#1486997)
+- Change reply prefix to display email address only if sender name doesn't exist (#1486550)
RELEASE 0.4.1
-------------
diff --git a/program/steps/mail/compose.inc b/program/steps/mail/compose.inc
index 5a66af141..b9594a09f 100644
--- a/program/steps/mail/compose.inc
+++ b/program/steps/mail/compose.inc
@@ -624,9 +624,14 @@ function rcmail_create_reply_body($body, $bodyIsHtml)
{
global $RCMAIL, $MESSAGE, $LINE_LENGTH;
+ // build reply prefix
+ $from = array_pop($RCMAIL->imap->decode_address_list($MESSAGE->get_header('from')));
+ $prefix = sprintf("On %s, %s wrote:",
+ $MESSAGE->headers->date, $from['name'] ? $from['name'] : idn_to_utf8($from['email']));
+
if (!$bodyIsHtml) {
$body = preg_replace('/\r?\n/', "\n", $body);
-
+
// try to remove the signature
if ($RCMAIL->config->get('strip_existing_sig', true)) {
$len = strlen($body);
@@ -644,13 +649,9 @@ function rcmail_create_reply_body($body, $bodyIsHtml)
// soft-wrap and quote message text
$body = rcmail_wrap_and_quote(rtrim($body, "\n"), $LINE_LENGTH);
- // add title line(s)
- $prefix = sprintf("On %s, %s wrote:\n",
- $MESSAGE->headers->date,
- $MESSAGE->get_header('from'));
-
+ $prefix .= "\n";
$suffix = '';
-
+
if ($RCMAIL->config->get('top_posting'))
$prefix = "\n\n\n" . $prefix;
}
@@ -663,9 +664,7 @@ function rcmail_create_reply_body($body, $bodyIsHtml)
$body = rcmail_wash_html($body, array('safe' => $MESSAGE->is_safe), $cid_map);
// build reply (quote content)
- $prefix = sprintf("<p>On %s, %s wrote:</p>\n",
- $MESSAGE->headers->date,
- htmlspecialchars(Q($MESSAGE->get_header('from'), 'replace'), ENT_COMPAT, $RCMAIL->output->get_charset()));
+ $prefix = '<p>' . Q($prefix) . "</p>\n";
$prefix .= '<blockquote>';
if ($RCMAIL->config->get('top_posting')) {