diff options
-rw-r--r-- | CHANGELOG | 1 | ||||
-rw-r--r-- | config/main.inc.php.dist | 6 | ||||
-rw-r--r-- | program/js/app.js | 10 | ||||
-rw-r--r-- | program/steps/mail/check_recent.inc | 2 | ||||
-rw-r--r-- | program/steps/mail/func.inc | 110 | ||||
-rw-r--r-- | program/steps/mail/list.inc | 10 | ||||
-rw-r--r-- | program/steps/mail/mark.inc | 9 | ||||
-rw-r--r-- | program/steps/mail/move_del.inc | 7 | ||||
-rw-r--r-- | program/steps/mail/pagenav.inc | 2 | ||||
-rw-r--r-- | program/steps/mail/search.inc | 4 | ||||
-rw-r--r-- | skins/default/functions.js | 16 | ||||
-rw-r--r-- | skins/default/mail.css | 1 | ||||
-rw-r--r-- | skins/default/templates/mail.html | 8 |
13 files changed, 119 insertions, 67 deletions
@@ -1,6 +1,7 @@ CHANGELOG Roundcube Webmail =========================== +- Added separate From and To columns apart from smart From/To column (#1486891) - Fix (workaround) delete operations with some versions of memcache (#1488592) - Fix wrong compose screen elements focus in IE9 (#1488541) - Fix redirect to mail/compose on re-login (#1488226) diff --git a/config/main.inc.php.dist b/config/main.inc.php.dist index 1837a6390..7788c0b50 100644 --- a/config/main.inc.php.dist +++ b/config/main.inc.php.dist @@ -365,15 +365,15 @@ $rcmail_config['plugins'] = array(); // ---------------------------------- // default messages sort column. Use empty value for default server's sorting, -// or 'arrival', 'date', 'subject', 'from', 'to', 'size', 'cc' +// or 'arrival', 'date', 'subject', 'from', 'to', 'fromto', 'size', 'cc' $rcmail_config['message_sort_col'] = ''; // default messages sort order $rcmail_config['message_sort_order'] = 'DESC'; // These cols are shown in the message list. Available cols are: -// subject, from, to, cc, replyto, date, size, status, flag, attachment, 'priority' -$rcmail_config['list_cols'] = array('subject', 'status', 'from', 'date', 'size', 'flag', 'attachment'); +// subject, from, to, fromto, cc, replyto, date, size, status, flag, attachment, 'priority' +$rcmail_config['list_cols'] = array('subject', 'status', 'fromto', 'date', 'size', 'flag', 'attachment'); // the default locale setting (leave empty for auto-detection) // RFC1766 formatted language name like en_US, de_DE, de_CH, fr_FR, pt_BR diff --git a/program/js/app.js b/program/js/app.js index 0db174625..8ec209539 100644 --- a/program/js/app.js +++ b/program/js/app.js @@ -1600,7 +1600,7 @@ function rcube_webmail() for (i=0; i<cols.length; i++) if (cols[i].id && cols[i].id.match(/^rcm/)) { name = cols[i].id.replace(/^rcm/, ''); - this.env.coltypes.push(name == 'to' ? 'from' : name); + this.env.coltypes.push(name); } if ((found = $.inArray('flag', this.env.coltypes)) >= 0) @@ -1875,7 +1875,7 @@ function rcube_webmail() // make sure new columns are added at the end of the list var i, idx, name, newcols = [], oldcols = this.env.coltypes; for (i=0; i<oldcols.length; i++) { - name = oldcols[i] == 'to' ? 'from' : oldcols[i]; + name = oldcols[i]; idx = $.inArray(name, cols); if (idx != -1) { newcols.push(name); @@ -5484,7 +5484,7 @@ function rcube_webmail() // for reordering column array (Konqueror workaround) // and for setting some message list global variables - this.set_message_coltypes = function(coltypes, repl) + this.set_message_coltypes = function(coltypes, repl, smart_col) { var list = this.message_list, thead = list ? list.list.tHead : null, @@ -5512,7 +5512,7 @@ function rcube_webmail() for (n=0, len=this.env.coltypes.length; n<len; n++) { col = this.env.coltypes[n]; - if ((cell = thead.rows[0].cells[n]) && (col=='from' || col=='to')) { + if ((cell = thead.rows[0].cells[n]) && (col == 'from' || col == 'to' || col == 'fromto')) { cell.id = 'rcm'+col; // if we have links for sorting, it's a bit more complicated... if (cell.firstChild && cell.firstChild.tagName.toLowerCase()=='a') { @@ -5520,7 +5520,7 @@ function rcube_webmail() cell.onclick = function(){ return rcmail.command('sort', this.__col, this); }; cell.__col = col; } - cell.innerHTML = this.get_label(col); + cell.innerHTML = this.get_label(col == 'fromto' ? smart_col : col); } } } diff --git a/program/steps/mail/check_recent.inc b/program/steps/mail/check_recent.inc index e22cccca5..4ec27c0ba 100644 --- a/program/steps/mail/check_recent.inc +++ b/program/steps/mail/check_recent.inc @@ -88,7 +88,7 @@ foreach ($a_mailboxes as $mbox_name) { $OUTPUT->command('message_list.clear', $all_count ? false : true); if ($all_count) { - $a_headers = $IMAP->list_headers($mbox_name, null, $_SESSION['sort_col'], $_SESSION['sort_order']); + $a_headers = $IMAP->list_headers($mbox_name, null, rcmail_sort_column(), rcmail_sort_order()); // add message rows rcmail_js_message_list($a_headers, false); // remove messages that don't exists from list selection array diff --git a/program/steps/mail/func.inc b/program/steps/mail/func.inc index ab0605d46..6cb7b7592 100644 --- a/program/steps/mail/func.inc +++ b/program/steps/mail/func.inc @@ -89,7 +89,7 @@ if (empty($RCMAIL->action) || $RCMAIL->action == 'list') { if ($_SESSION['search_filter'] && $_SESSION['search_filter'] != 'ALL') { $search_request = md5($mbox_name.$_SESSION['search_filter']); - $IMAP->search($mbox_name, $_SESSION['search_filter'], RCMAIL_CHARSET, $_SESSION['sort_col']); + $IMAP->search($mbox_name, $_SESSION['search_filter'], RCMAIL_CHARSET, rcmail_sort_column()); $_SESSION['search'] = $IMAP->get_search_set(); $_SESSION['search_request'] = $search_request; $OUTPUT->set_env('search_request', $search_request); @@ -133,13 +133,76 @@ if (empty($RCMAIL->action) || $RCMAIL->action == 'list') { $OUTPUT->set_pagetitle(rcmail_localize_foldername($IMAP->mod_mailbox($mbox_name))); } +/** + * Returns 'to' if current folder is configured Sent or Drafts + * or their subfolders, otherwise returns 'from'. + * + * @return string Column name + */ +function rcmail_message_list_smart_column_name() +{ + global $RCMAIL; + + $delim = $RCMAIL->imap->get_hierarchy_delimiter(); + $mbox = $RCMAIL->imap->get_mailbox_name(); + $sent_mbox = $RCMAIL->config->get('sent_mbox'); + $drafts_mbox = $RCMAIL->config->get('drafts_mbox'); + + if (strpos($mbox.$delim, $sent_mbox.$delim) === 0 || strpos($mbox.$delim, $drafts_mbox.$delim) === 0) { + return 'to'; + } + + return 'from'; +} + +/** + * Returns configured messages list sorting column name + * The name is context-sensitive, which means if sorting is set to 'fromto' + * it will return 'from' or 'to' according to current folder type. + * + * @return string Column name + */ +function rcmail_sort_column() +{ + global $RCMAIL; + + if (isset($_SESSION['sort_col'])) { + $column = $_SESSION['sort_col']; + } + else { + $column = $RCMAIL->config->get('message_sort_col'); + } + + // get name of smart From/To column in folder context + if ($column == 'fromto') { + $column = rcmail_message_list_smart_column_name(); + } + + return $column; +} + +/** + * Returns configured message list sorting order + * + * @return string Sorting order (ASC|DESC) + */ +function rcmail_sort_order() +{ + global $RCMAIL; + + if (isset($_SESSION['sort_order'])) { + return $_SESSION['sort_order']; + } + + return $RCMAIL->config->get('message_sort_order'); +} /** * return the message list as HTML table */ function rcmail_message_list($attrib) { - global $IMAP, $CONFIG, $OUTPUT; + global $CONFIG, $OUTPUT; // add some labels to client $OUTPUT->add_label('from', 'to'); @@ -161,14 +224,6 @@ function rcmail_message_list($attrib) // save some variables for use in ajax list $_SESSION['list_attrib'] = $attrib; - $mbox = $IMAP->get_mailbox_name(); - $delim = $IMAP->get_hierarchy_delimiter(); - - // show 'to' instead of 'from' in sent/draft messages - if ((strpos($mbox.$delim, $CONFIG['sent_mbox'].$delim)===0 || strpos($mbox.$delim, $CONFIG['drafts_mbox'].$delim)===0) - && (($f = array_search('from', $a_show_cols)) !== false) && array_search('to', $a_show_cols) === false) - $a_show_cols[$f] = 'to'; - // make sure 'threads' and 'subject' columns are present if (!in_array('subject', $a_show_cols)) array_unshift($a_show_cols, 'subject'); @@ -219,7 +274,6 @@ function rcmail_js_message_list($a_headers, $insert_top=FALSE, $a_show_cols=null } $mbox = $IMAP->get_mailbox_name(); - $delim = $IMAP->get_hierarchy_delimiter(); // make sure 'threads' and 'subject' columns are present if (!in_array('subject', $a_show_cols)) @@ -229,11 +283,6 @@ function rcmail_js_message_list($a_headers, $insert_top=FALSE, $a_show_cols=null $_SESSION['list_attrib']['columns'] = $a_show_cols; - // show 'to' instead of 'from' in sent/draft messages - if ((strpos($mbox.$delim, $CONFIG['sent_mbox'].$delim)===0 || strpos($mbox.$delim, $CONFIG['drafts_mbox'].$delim)===0) - && (($f = array_search('from', $a_show_cols)) !== false) && array_search('to', $a_show_cols) === false) - $a_show_cols[$f] = 'to'; - // Make sure there are no duplicated columns (#1486999) $a_show_cols = array_unique($a_show_cols); @@ -247,7 +296,12 @@ function rcmail_js_message_list($a_headers, $insert_top=FALSE, $a_show_cols=null $thead = $head_replace ? rcmail_message_list_head($_SESSION['list_attrib'], $a_show_cols) : NULL; - $OUTPUT->command('set_message_coltypes', $a_show_cols, $thead); + // get name of smart From/To column in folder context + if (($f = array_search('fromto', $a_show_cols)) !== false) { + $smart_col = rcmail_message_list_smart_column_name(); + } + + $OUTPUT->command('set_message_coltypes', $a_show_cols, $thead, $smart_col); if (empty($a_headers)) return; @@ -270,16 +324,18 @@ function rcmail_js_message_list($a_headers, $insert_top=FALSE, $a_show_cols=null // format each col; similar as in rcmail_message_list() foreach ($a_show_cols as $col) { - if (in_array($col, array('from', 'to', 'cc', 'replyto'))) - $cont = Q(rcmail_address_string($header->$col, 3), 'show'); + $col_name = $col == 'fromto' ? $smart_col : $col; + + if (in_array($col_name, array('from', 'to', 'cc', 'replyto'))) + $cont = Q(rcmail_address_string($header->$col_name, 3), 'show'); else if ($col=='subject') { $cont = trim($IMAP->decode_header($header->$col)); if (!$cont) $cont = rcube_label('nosubject'); $cont = Q($cont); } - else if ($col=='size') + else if ($col == 'size') $cont = show_bytes($header->$col); - else if ($col=='date') + else if ($col == 'date') $cont = format_date($header->date); else $cont = Q($header->$col); @@ -330,8 +386,6 @@ function rcmail_js_message_list($a_headers, $insert_top=FALSE, $a_show_cols=null */ function rcmail_message_list_head($attrib, $a_show_cols) { - global $CONFIG; - $skin_path = $_SESSION['skin_path']; $image_tag = html::img(array('src' => "%s%s", 'alt' => "%s")); @@ -340,7 +394,7 @@ function rcmail_message_list_head($attrib, $a_show_cols) $sort_order = $_SESSION['sort_order']; // define sortable columns - $a_sort_cols = array('subject', 'date', 'from', 'to', 'size', 'cc'); + $a_sort_cols = array('subject', 'date', 'from', 'to', 'fromto', 'size', 'cc'); if (!empty($attrib['optionsmenuicon'])) { $onclick = 'return ' . JS_OBJECT_NAME . ".command('menu-open', 'messagelistmenu')"; @@ -358,6 +412,11 @@ function rcmail_message_list_head($attrib, $a_show_cols) $cells = array(); + // get name of smart From/To column in folder context + if (($f = array_search('fromto', $a_show_cols)) !== false) { + $smart_col = rcmail_message_list_smart_column_name(); + } + foreach ($a_show_cols as $col) { // get column name switch ($col) { @@ -372,6 +431,9 @@ function rcmail_message_list_head($attrib, $a_show_cols) case 'threads': $col_name = $list_menu; break; + case 'fromto': + $col_name = Q(rcube_label($smart_col)); + break; default: $col_name = Q(rcube_label($col)); } diff --git a/program/steps/mail/list.inc b/program/steps/mail/list.inc index 9988a00b4..1a7d05577 100644 --- a/program/steps/mail/list.inc +++ b/program/steps/mail/list.inc @@ -34,12 +34,6 @@ if ($sort = get_input_value('_sort', RCUBE_INPUT_GET)) $_SESSION['sort_col'] = $save_arr['message_sort_col'] = $sort_col; $_SESSION['sort_order'] = $save_arr['message_sort_order'] = $sort_order; } -else -{ - // use session settings if set, defaults if not - $sort_col = isset($_SESSION['sort_col']) ? $_SESSION['sort_col'] : $CONFIG['message_sort_col']; - $sort_order = isset($_SESSION['sort_order']) ? $_SESSION['sort_order'] : $CONFIG['message_sort_order']; -} // is there a set of columns for this request? if ($cols = get_input_value('_cols', RCUBE_INPUT_GET)) @@ -60,7 +54,7 @@ $IMAP->mailbox_sync($mbox_name); if ($_SESSION['search_filter'] && $_SESSION['search_filter'] != 'ALL') { $search_request = md5($mbox_name.$_SESSION['search_filter']); - $IMAP->search($mbox_name, $_SESSION['search_filter'], RCMAIL_CHARSET, $sort_col); + $IMAP->search($mbox_name, $_SESSION['search_filter'], RCMAIL_CHARSET, rcmail_sort_column()); $_SESSION['search'] = $IMAP->get_search_set(); $_SESSION['search_request'] = $search_request; $OUTPUT->set_env('search_request', $search_request); @@ -68,7 +62,7 @@ if ($_SESSION['search_filter'] && $_SESSION['search_filter'] != 'ALL') // fetch message headers if ($count = $IMAP->messagecount($mbox_name, $IMAP->threading ? 'THREADS' : 'ALL', !empty($_REQUEST['_refresh']))) - $a_headers = $IMAP->list_headers($mbox_name, NULL, $sort_col, $sort_order); + $a_headers = $IMAP->list_headers($mbox_name, NULL, rcmail_sort_column(), rcmail_sort_order()); // update search set (possible change of threading mode) if (!empty($_REQUEST['_search']) && isset($_SESSION['search']) diff --git a/program/steps/mail/mark.inc b/program/steps/mail/mark.inc index c232d8c48..710a77e0f 100644 --- a/program/steps/mail/mark.inc +++ b/program/steps/mail/mark.inc @@ -107,15 +107,12 @@ if (($uids = get_input_value('_uid', RCUBE_INPUT_POST)) && ($flag = get_input_va $OUTPUT->command('set_rowcount', rcmail_get_messagecount_text($msg_count), $mbox); if ($IMAP->threading) - $count = get_input_value('_count', RCUBE_INPUT_POST); + $count = get_input_value('_count', RCUBE_INPUT_POST); // add new rows from next page (if any) if ($count && $uids != '*' && ($jump_back || $nextpage_count > 0)) { - $sort_col = isset($_SESSION['sort_col']) ? $_SESSION['sort_col'] : $CONFIG['message_sort_col']; - $sort_order = isset($_SESSION['sort_order']) ? $_SESSION['sort_order'] : $CONFIG['message_sort_order']; - - $a_headers = $IMAP->list_headers($mbox, NULL, $sort_col, $sort_order, - $jump_back ? NULL : $count); + $a_headers = $IMAP->list_headers($mbox, NULL, + rcmail_sort_column(), rcmail_sort_order(), $jump_back ? NULL : $count); rcmail_js_message_list($a_headers, false); } diff --git a/program/steps/mail/move_del.inc b/program/steps/mail/move_del.inc index a42bc90cd..02504875e 100644 --- a/program/steps/mail/move_del.inc +++ b/program/steps/mail/move_del.inc @@ -128,11 +128,8 @@ else // add new rows from next page (if any) if ($addrows && $count && $uids != '*' && ($jump_back || $nextpage_count > 0)) { - $sort_col = isset($_SESSION['sort_col']) ? $_SESSION['sort_col'] : $CONFIG['message_sort_col']; - $sort_order = isset($_SESSION['sort_order']) ? $_SESSION['sort_order'] : $CONFIG['message_sort_order']; - - $a_headers = $IMAP->list_headers($mbox, NULL, $sort_col, $sort_order, - $jump_back ? NULL : $count); + $a_headers = $IMAP->list_headers($mbox, NULL, + rcmail_sort_column(), rcmail_sort_order(), $jump_back ? NULL : $count); rcmail_js_message_list($a_headers, false); } diff --git a/program/steps/mail/pagenav.inc b/program/steps/mail/pagenav.inc index 974b3b46f..a1f00b61c 100644 --- a/program/steps/mail/pagenav.inc +++ b/program/steps/mail/pagenav.inc @@ -42,7 +42,7 @@ if ($_SESSION['sort_col'] == 'date' && $_SESSION['sort_order'] == 'DESC' } else { // Only if we use custom sorting - $a_msg_index = $IMAP->message_index(NULL, $_SESSION['sort_col'], $_SESSION['sort_order']); + $a_msg_index = $IMAP->message_index(NULL, rcmail_sort_column(), rcmail_sort_order()); $index = array_search($IMAP->get_id($uid), $a_msg_index); diff --git a/program/steps/mail/search.inc b/program/steps/mail/search.inc index 49f31e0c1..ab026d5f3 100644 --- a/program/steps/mail/search.inc +++ b/program/steps/mail/search.inc @@ -107,10 +107,10 @@ $search_str = trim($search_str); // execute IMAP search if ($search_str) - $IMAP->search($mbox, $search_str, $imap_charset, $_SESSION['sort_col']); + $IMAP->search($mbox, $search_str, $imap_charset, rcmail_sort_column()); // Get the headers -$result_h = $IMAP->list_headers($mbox, 1, $_SESSION['sort_col'], $_SESSION['sort_order']); +$result_h = $IMAP->list_headers($mbox, 1, rcmail_sort_column(), rcmail_sort_order()); $count = $IMAP->messagecount(NULL, $IMAP->threading ? 'THREADS' : 'ALL'); // save search results in session diff --git a/skins/default/functions.js b/skins/default/functions.js index 8482e375a..3faf9281f 100644 --- a/skins/default/functions.js +++ b/skins/default/functions.js @@ -285,22 +285,18 @@ listmenu: function(show) pos.left = pos.left - menuwidth; obj.css({ left:pos.left, top:(pos.top + ref.offsetHeight + 2)}); + // set form values $('input[name="sort_col"][value="'+rcmail.env.sort_col+'"]').prop('checked', true); $('input[name="sort_ord"][value="DESC"]').prop('checked', rcmail.env.sort_order == 'DESC'); $('input[name="sort_ord"][value="ASC"]').prop('checked', rcmail.env.sort_order != 'DESC'); $('input[name="view"][value="thread"]').prop('checked', rcmail.env.threading ? true : false); $('input[name="view"][value="list"]').prop('checked', rcmail.env.threading ? false : true); - // list columns - var found, cols = $('input[name="list_col[]"]'); - for (var i=0; i<cols.length; i++) { - if (cols[i].value != 'from') - found = jQuery.inArray(cols[i].value, rcmail.env.coltypes) != -1; - else - found = (jQuery.inArray('from', rcmail.env.coltypes) != -1 - || jQuery.inArray('to', rcmail.env.coltypes) != -1); - $(cols[i]).prop('checked', found); - } + + // set checkboxes + $('input[name="list_col[]"]').each(function() { + $(this).prop('checked', jQuery.inArray(this.value, rcmail.env.coltypes) != -1); + }); } obj[show?'show':'hide'](); diff --git a/skins/default/mail.css b/skins/default/mail.css index 4dfc20674..46548f386 100644 --- a/skins/default/mail.css +++ b/skins/default/mail.css @@ -891,6 +891,7 @@ body.messagelist padding: 0 2px; } +#messagelist tr td.fromto, #messagelist tr td.from, #messagelist tr td.to, #messagelist tr td.cc, diff --git a/skins/default/templates/mail.html b/skins/default/templates/mail.html index 30b56aa41..5b6565184 100644 --- a/skins/default/templates/mail.html +++ b/skins/default/templates/mail.html @@ -158,7 +158,9 @@ <ul class="toolbarmenu"> <li><input type="checkbox" name="list_col[]" value="threads" id="cols_threads" checked="checked" disabled="disabled" /><label for="cols_threads" class="disabled"><roundcube:label name="threads" /></label></li> <li><input type="checkbox" name="list_col[]" value="subject" id="cols_subject" checked="checked" disabled="disabled" /><label for="cols_subject" class="disabled"><roundcube:label name="subject" /></label></li> - <li><input type="checkbox" name="list_col[]" value="from" id="cols_fromto" /><label for="cols_fromto"><roundcube:label name="fromto" /></label></li> + <li><input type="checkbox" name="list_col[]" value="fromto" id="cols_fromto" /><label for="cols_fromto"><roundcube:label name="fromto" /></label></li> + <li><input type="checkbox" name="list_col[]" value="from" id="cols_from" /><label for="cols_from"><roundcube:label name="from" /></label></li> + <li><input type="checkbox" name="list_col[]" value="to" id="cols_to" /><label for="cols_to"><roundcube:label name="to" /></label></li> <li><input type="checkbox" name="list_col[]" value="replyto" id="cols_replyto" /><label for="cols_replyto"><roundcube:label name="replyto" /></label></li> <li><input type="checkbox" name="list_col[]" value="cc" id="cols_cc" /><label for="cols_cc"><roundcube:label name="cc" /></label></li> <li><input type="checkbox" name="list_col[]" value="date" id="cols_date" /><label for="cols_date"><roundcube:label name="date" /></label></li> @@ -177,7 +179,9 @@ <li><input type="radio" name="sort_col" value="arrival" id="sort_arrival" /><label for="sort_arrival"><roundcube:label name="arrival" /></label></li> <li><input type="radio" name="sort_col" value="date" id="sort_date" /><label for="sort_date"><roundcube:label name="sentdate" /></label></li> <li><input type="radio" name="sort_col" value="subject" id="sort_subject" /><label for="sort_subject"><roundcube:label name="subject" /></label></li> - <li><input type="radio" name="sort_col" value="from" id="sort_fromto" /><label for="sort_fromto"><roundcube:label name="fromto" /></label></li> + <li><input type="radio" name="sort_col" value="fromto" id="sort_fromto" /><label for="sort_fromto"><roundcube:label name="fromto" /></label></li> + <li><input type="radio" name="sort_col" value="from" id="sort_from" /><label for="sort_from"><roundcube:label name="from" /></label></li> + <li><input type="radio" name="sort_col" value="to" id="sort_to" /><label for="sort_to"><roundcube:label name="to" /></label></li> <li><input type="radio" name="sort_col" value="to" id="sort_replyto" /><label for="sort_replyto"><roundcube:label name="replyto" /></label></li> <li><input type="radio" name="sort_col" value="cc" id="sort_cc" /><label for="sort_cc"><roundcube:label name="cc" /></label></li> <li><input type="radio" name="sort_col" value="size" id="sort_size" /><label for="sort_size"><roundcube:label name="size" /></label></li> |