diff options
Diffstat (limited to 'installer')
-rw-r--r-- | installer/check.php | 25 | ||||
-rw-r--r-- | installer/config.php | 9 | ||||
-rw-r--r-- | installer/rcube_install.php | 94 | ||||
-rw-r--r-- | installer/test.php | 4 | ||||
-rw-r--r-- | installer/utils.php | 2 |
5 files changed, 29 insertions, 105 deletions
diff --git a/installer/check.php b/installer/check.php index e5f30261c..3136563b1 100644 --- a/installer/check.php +++ b/installer/check.php @@ -6,7 +6,8 @@ $required_php_exts = array( 'DOM' => 'dom', 'Session' => 'session', 'XML' => 'xml', - 'JSON' => 'json' + 'JSON' => 'json', + 'PDO' => 'PDO', ); $optional_php_exts = array( @@ -21,19 +22,11 @@ $optional_php_exts = array( $required_libs = array( 'PEAR' => 'PEAR.php', - 'MDB2' => 'MDB2.php', 'Net_SMTP' => 'Net/SMTP.php', 'Net_IDNA2' => 'Net/IDNA2.php', 'Mail_mime' => 'Mail/mime.php', ); -$supported_dbs = array( - 'MySQL' => 'mysql', - 'MySQLi' => 'mysqli', - 'PostgreSQL' => 'pgsql', - 'SQLite (v2)' => 'sqlite', -); - $ini_checks = array( 'file_uploads' => 1, 'session.auto_start' => 0, @@ -61,8 +54,14 @@ $source_urls = array( 'DOM' => 'http://www.php.net/manual/en/book.dom.php', 'Intl' => 'http://www.php.net/manual/en/book.intl.php', 'Exif' => 'http://www.php.net/manual/en/book.exif.php', + 'PDO' => 'http://www.php.net/manual/en/book.pdo.php', + 'pdo_mysql' => 'http://www.php.net/manual/en/book.pdo-mysql.php', + 'pdo_pgsql' => 'http://www.php.net/manual/en/book.pdo-pgsql.php', + 'pdo_sqlite' => 'http://www.php.net/manual/en/book.pdo-sqlite.php', + 'pdo_sqlite2' => 'http://www.php.net/manual/en/book.pdo-sqlite.php', + 'pdo_sqlsrv' => 'http://www.php.net/manual/en/book.pdo-sqlsrv.php', + 'pdo_dblib' => 'http://www.php.net/manual/en/book.pdo-dblib.php', 'PEAR' => 'http://pear.php.net', - 'MDB2' => 'http://pear.php.net/package/MDB2', 'Net_SMTP' => 'http://pear.php.net/package/Net_SMTP', 'Mail_mime' => 'http://pear.php.net/package/Mail_mime', 'Net_IDNA2' => 'http://pear.php.net/package/Net_IDNA2', @@ -127,14 +126,14 @@ foreach ($optional_php_exts as $name => $ext) { <?php $prefix = (PHP_SHLIB_SUFFIX === 'dll') ? 'php_' : ''; -foreach ($supported_dbs as $database => $ext) { +foreach ($RCI->supported_dbs as $database => $ext) { if (extension_loaded($ext)) { $RCI->pass($database); } else { $_ext = $ext_dir . '/' . $prefix . $ext . '.' . PHP_SHLIB_SUFFIX; - $msg = @is_readable($_ext) ? 'Could be loaded. Please add in php.ini' : 'Not installed'; - $RCI->na($database, $msg, $source_urls[$database]); + $msg = @is_readable($_ext) ? 'Could be loaded. Please add in php.ini' : ''; + $RCI->na($database, $msg, $source_urls[$ext]); } echo '<br />'; } diff --git a/installer/config.php b/installer/config.php index bd676b12e..905fb06a3 100644 --- a/installer/config.php +++ b/installer/config.php @@ -267,13 +267,8 @@ echo $input_syslogfacility->show($RCI->getprop('syslog_facility'), LOG_USER); <p>Database settings for read/write operations:</p> <?php -require_once 'MDB2.php'; - -$supported_dbs = array('MySQL' => 'mysql', 'MySQLi' => 'mysqli', - 'PgSQL' => 'pgsql', 'SQLite' => 'sqlite'); - $select_dbtype = new html_select(array('name' => '_dbtype', 'id' => "cfgdbtype")); -foreach ($supported_dbs AS $database => $ext) { +foreach ($RCI->supported_dbs as $database => $ext) { if (extension_loaded($ext)) { $select_dbtype->add($database, $ext); } @@ -284,7 +279,7 @@ $input_dbname = new html_inputfield(array('name' => '_dbname', 'size' => 20, 'id $input_dbuser = new html_inputfield(array('name' => '_dbuser', 'size' => 20, 'id' => "cfgdbuser")); $input_dbpass = new html_passwordfield(array('name' => '_dbpass', 'size' => 20, 'id' => "cfgdbpass")); -$dsnw = MDB2::parseDSN($RCI->getprop('db_dsnw')); +$dsnw = rcube_db::parse_dsn($RCI->getprop('db_dsnw')); echo $select_dbtype->show($RCI->is_post ? $_POST['_dbtype'] : $dsnw['phptype']); echo '<label for="cfgdbtype">Database type</label><br />'; diff --git a/installer/rcube_install.php b/installer/rcube_install.php index 01238596b..331e29625 100644 --- a/installer/rcube_install.php +++ b/installer/rcube_install.php @@ -50,6 +50,17 @@ class rcube_install 'des_key', 'session_lifetime', 'support_url', ); + // list of supported database drivers + var $supported_dbs = array( + 'MySQL' => 'pdo_mysql', + 'PostgreSQL' => 'pdo_pgsql', + 'SQLite' => 'pdo_sqlite', + 'SQLite (v2)' => 'pdo_sqlite2', + 'SQL Server (SQLSRV)' => 'pdo_sqlsrv', + 'SQL Server (DBLIB)' => 'pdo_dblib', + ); + + /** * Constructor */ @@ -371,7 +382,7 @@ class rcube_install $errors[] = "Missing columns in table '$table': " . join(',', $diff); } } - + return !empty($errors) ? $errors : false; } @@ -394,87 +405,8 @@ class rcube_install } } } - - return $schema; - } - - - /** - * Compare the local database schema with the reference schema - * required for this version of Roundcube - * - * @param boolean True if the schema schould be updated - * @return boolean True if the schema is up-to-date, false if not or an error occured - */ - function mdb2_schema_check($update = false) - { - if (!$this->configured) - return false; - - $options = array( - 'use_transactions' => false, - 'log_line_break' => "\n", - 'idxname_format' => '%s', - 'debug' => false, - 'quote_identifier' => true, - 'force_defaults' => false, - 'portability' => true - ); - - $dsnw = $this->config['db_dsnw']; - $schema = MDB2_Schema::factory($dsnw, $options); - $schema->db->supported['transactions'] = false; - - if (PEAR::isError($schema)) { - $this->raise_error(array('code' => $schema->getCode(), 'message' => $schema->getMessage() . ' ' . $schema->getUserInfo())); - return false; - } - else { - $definition = $schema->getDefinitionFromDatabase(); - $definition['charset'] = 'utf8'; - - if (PEAR::isError($definition)) { - $this->raise_error(array('code' => $definition->getCode(), 'message' => $definition->getMessage() . ' ' . $definition->getUserInfo())); - return false; - } - - // load reference schema - $dsn_arr = MDB2::parseDSN($this->config['db_dsnw']); - - $ref_schema = INSTALL_PATH . 'SQL/' . $dsn_arr['phptype'] . '.schema.xml'; - - if (is_readable($ref_schema)) { - $reference = $schema->parseDatabaseDefinition($ref_schema, false, array(), $schema->options['fail_on_invalid_names']); - - if (PEAR::isError($reference)) { - $this->raise_error(array('code' => $reference->getCode(), 'message' => $reference->getMessage() . ' ' . $reference->getUserInfo())); - } - else { - $diff = $schema->compareDefinitions($reference, $definition); - - if (empty($diff)) { - return true; - } - else if ($update) { - // update database schema with the diff from the above check - $success = $schema->alterDatabase($reference, $definition, $diff); - - if (PEAR::isError($success)) { - $this->raise_error(array('code' => $success->getCode(), 'message' => $success->getMessage() . ' ' . $success->getUserInfo())); - } - else - return true; - } - echo '<pre>'; var_dump($diff); echo '</pre>'; - return false; - } - } - else - $this->raise_error(array('message' => "Could not find reference schema file ($ref_schema)")); - return false; - } - return false; + return $schema; } diff --git a/installer/test.php b/installer/test.php index 2dd330531..87896009c 100644 --- a/installer/test.php +++ b/installer/test.php @@ -125,9 +125,9 @@ else { $db_working = false; if ($RCI->configured) { if (!empty($RCI->config['db_dsnw'])) { - - $DB = new rcube_mdb2($RCI->config['db_dsnw'], '', false); + $DB = new rcube_db::factory($RCI->config['db_dsnw'], '', false); $DB->db_connect('w'); + if (!($db_error_msg = $DB->is_error())) { $RCI->pass('DSN (write)'); echo '<br />'; diff --git a/installer/utils.php b/installer/utils.php index 6c67d25c2..0e6cfecf3 100644 --- a/installer/utils.php +++ b/installer/utils.php @@ -23,7 +23,6 @@ function __autoload($classname) { $filename = preg_replace( array( - '/MDB2_(.+)/', '/Mail_(.+)/', '/Net_(.+)/', '/Auth_(.+)/', @@ -31,7 +30,6 @@ function __autoload($classname) '/^utf8$/' ), array( - 'MDB2/\\1', 'Mail/\\1', 'Net/\\1', 'Auth/\\1', |