1 files changed, 28 insertions, 25 deletions

diff --git a/program/lib/Roundcube/rcube_imap.php b/program/lib/Roundcube/rcube_imap.php
index e4b77a0a3..e29bfc46b 100644
--- a/program/lib/Roundcube/rcube_imap.php
+++ b/program/lib/Roundcube/rcube_imap.php
@@ -2990,7 +2990,7 @@ class rcube_imap extends rcube_storage
      * @param array  $result  Reference to folders list
      * @param string $type    Listing type (ext-subscribed, subscribed or all)
      */
-    private function list_folders_update(&$result, $type = null)
+    protected function list_folders_update(&$result, $type = null)
     {
         $namespace = $this->get_namespace();
         $search    = array();
@@ -4142,19 +4142,15 @@ class rcube_imap extends rcube_storage
      */
     public function sort_folder_list($a_folders, $skip_default = false)
     {
-        $delimiter = $this->get_hierarchy_delimiter();
         $specials  = array_merge(array('INBOX'), array_values($this->get_special_folders()));
-        $folders   = array_flip($a_folders);
+        $folders   = array();
 
         // convert names to UTF-8 and skip folders starting with '.'
         foreach ($a_folders as $folder) {
             if ($folder[0] != '.') {
                 // for better performance skip encoding conversion
                 // if the string does not look like UTF7-IMAP
-                $folders[$folder] = strpos($folder, '+') === false ? $folder : rcube_charset::convert($folder, 'UTF7-IMAP');
-            }
-            else {
-                unset($folders[$idx]);
+                $folders[$folder] = strpos($folder, '&') === false ? $folder : rcube_charset::convert($folder, 'UTF7-IMAP');
             }
         }
 
@@ -4170,39 +4166,46 @@ class rcube_imap extends rcube_storage
 
         // force the type of folder name variable (#1485527)
         $folders  = array_map('strval', $folders);
+        $out      = array();
+
+        // finally we must put special folders on top and rebuild the list
+        // to move their subfolders where they belong...
         $specials = array_unique(array_intersect($specials, $folders));
-        $head     = array();
+        $folders  = array_merge($specials, array_diff($folders, $specials));
 
-        // place default folders on top
-        foreach ($specials as $special) {
-            $prefix = $special . $delimiter;
+        $this->sort_folder_specials(null, $folders, $specials, $out);
 
-            foreach ($folders as $idx => $folder) {
-                if ($folder === $special) {
-                    $head[] = $special;
-                    unset($folders[$idx]);
-                }
-                // put subfolders of default folders on their place...
-                else if (strpos($folder, $prefix) === 0) {
-                    $head[] = $folder;
-                    unset($folders[$idx]);
+        return $out;
+    }
+
+    /**
+     * Recursive function to put subfolders of special folders in place
+     */
+    protected function sort_folder_specials($folder, &$list, &$specials, &$out)
+    {
+        while (list($key, $name) = each($list)) {
+            if ($folder === null || strpos($name, $folder.$this->delimiter) === 0) {
+                $out[] = $name;
+                unset($list[$key]);
+
+                if (!empty($specials) && ($found = array_search($name, $specials)) !== false) {
+                    unset($specials[$found]);
+                    $this->sort_folder_specials($name, $list, $specials, $out);
                 }
             }
         }
 
-        return array_merge($head, $folders);
+        reset($list);
     }
 
-
     /**
      * Callback for uasort() that implements correct
      * locale-aware case-sensitive sorting
      */
     protected function sort_folder_comparator($str1, $str2)
     {
-        $delimiter = $this->get_hierarchy_delimiter();
-        $path1     = explode($delimiter, $str1);
-        $path2     = explode($delimiter, $str2);
+        $path1 = explode($this->delimiter, $str1);
+        $path2 = explode($this->delimiter, $str2);
 
         foreach ($path1 as $idx => $folder1) {
             $folder2 = $path2[$idx];