From 74be739c40eb3146b7a809f2277f07fc0ef65ab8 Mon Sep 17 00:00:00 2001 From: alecpl Date: Thu, 28 Jan 2010 14:46:26 +0000 Subject: - speed up templates parsing --- program/include/rcube_html_page.php | 34 +++++++++++++++++++++++----------- 1 file changed, 23 insertions(+), 11 deletions(-) diff --git a/program/include/rcube_html_page.php b/program/include/rcube_html_page.php index 36b56e076..628104324 100644 --- a/program/include/rcube_html_page.php +++ b/program/include/rcube_html_page.php @@ -39,6 +39,7 @@ class rcube_html_page protected $header = ''; protected $footer = ''; protected $body = ''; + protected $base_path = ''; /** Constructor */ @@ -196,14 +197,14 @@ class rcube_html_page } // find page header - if ($hpos = strpos(strtolower($output), '')) { + if ($hpos = stripos($output, '')) { $__page_header .= "\n"; } else { if (!is_numeric($hpos)) { - $hpos = strpos(strtolower($output), '')+7; + $bpos = stripos($output, '')+7; } // add page body @@ -237,8 +238,7 @@ class rcube_html_page } // find and add page footer - $output_lc = strtolower($output); - if (($fpos = strrpos($output_lc, '')) || ($fpos = strrpos($output_lc, ''))) { + if (($fpos = strripos($output, '')) || ($fpos = strripos($output, ''))) { $output = substr($output, 0, $fpos) . "$__page_footer\n" . substr($output, $fpos); } else { @@ -248,9 +248,11 @@ class rcube_html_page // reset those global vars $__page_header = $__page_footer = ''; + $this->base_path = $base_path; // correct absolute paths in images and other tags - $output = preg_replace('!(src|href|background)=(["\']?)(/[a-z0-9_-]+)!i', "\\1=\\2$base_path\\3", $output); - $output = preg_replace_callback('!(src|href)=(["\']?)([a-z0-9/_.-]+.(css|js))(["\'\s>])!i', array($this, 'add_filemtime'), $output); + // add timestamp to .js and .css filename + $output = preg_replace_callback('!(src|href|background)=(["\']?)([a-z0-9/_.-]+)(["\'\s>])!i', + array($this, 'file_callback'), $output); $output = str_replace('$__skin_path', $base_path, $output); if ($this->charset != RCMAIL_CHARSET) @@ -262,9 +264,19 @@ class rcube_html_page /** * Callback function for preg_replace_callback in write() */ - public function add_filemtime($matches) + private function file_callback($matches) { - return sprintf("%s=%s%s?s=%d%s", $matches[1], $matches[2], $matches[3], @filemtime($matches[3]), $matches[5]); + $file = $matches[3]; + + // correct absolute paths + if ($file[0] == '/') + $file = $this->base_path . $file; + + // add file modification timestamp + if (preg_match('/\.(js|css)$/', $file)) + $file .= '?s=' . @filemtime($file); + + return sprintf("%s=%s%s%s", $matches[1], $matches[2], $file, $matches[4]); } } -- cgit v1.2.3