From bb1398a54e8ba45f099435f6cc56c016f8662f65 Mon Sep 17 00:00:00 2001 From: Aleksander Machniak Date: Wed, 19 Nov 2014 08:46:43 +0100 Subject: Fix import of multiple contact groups from Google-csv format (#1490159) --- CHANGELOG | 1 + program/lib/Roundcube/rcube_csv2vcard.php | 5 ++++- tests/src/Csv2vcard/gmail.csv | Bin 3760 -> 3778 bytes tests/src/Csv2vcard/gmail.vcf | 2 +- 4 files changed, 6 insertions(+), 2 deletions(-) diff --git a/CHANGELOG b/CHANGELOG index 3a70bd0d0..09835e065 100644 --- a/CHANGELOG +++ b/CHANGELOG @@ -2,6 +2,7 @@ CHANGELOG Roundcube Webmail =========================== - Fix drag-n-drop to folders expanded while dragging (#1490157) +- Fix import of multiple contact groups from Google-csv format (#1490159) RELEASE 1.1-beta ---------------- diff --git a/program/lib/Roundcube/rcube_csv2vcard.php b/program/lib/Roundcube/rcube_csv2vcard.php index b7d159178..802ca730d 100644 --- a/program/lib/Roundcube/rcube_csv2vcard.php +++ b/program/lib/Roundcube/rcube_csv2vcard.php @@ -584,11 +584,14 @@ class rcube_csv2vcard if (!empty($contact['groups'])) { // categories/groups separator in vCard is ',' not ';' + $contact['groups'] = str_replace(',', '', $contact['groups']); $contact['groups'] = str_replace(';', ',', $contact['groups']); - // remove "* " added by GMail if (!empty($this->gmail_map)) { + // remove "* " added by GMail $contact['groups'] = str_replace('* ', '', $contact['groups']); + // replace strange delimiter + $contact['groups'] = str_replace(' ::: ', ',', $contact['groups']); } } diff --git a/tests/src/Csv2vcard/gmail.csv b/tests/src/Csv2vcard/gmail.csv index 9f67fe9f5..1de3033e7 100644 Binary files a/tests/src/Csv2vcard/gmail.csv and b/tests/src/Csv2vcard/gmail.csv differ diff --git a/tests/src/Csv2vcard/gmail.vcf b/tests/src/Csv2vcard/gmail.vcf index 5337d7e63..2a56311d3 100644 --- a/tests/src/Csv2vcard/gmail.vcf +++ b/tests/src/Csv2vcard/gmail.vcf @@ -5,7 +5,7 @@ N:Lastname;Firstname;Middle;Prefix;Suffix NICKNAME:nick BDAY;VALUE=date:1975-12-12 NOTE:note"note -CATEGORIES:My Contacts +CATEGORIES:My Contacts,Test EMAIL;TYPE=INTERNET;TYPE=HOME:home@aaa.pl EMAIL;TYPE=INTERNET;TYPE=WORK:work@email.pl TEL;TYPE=pager:pager -- cgit v1.2.3