From f23ef1c96859f6b01a9268c8606a22ceb719cf3d Mon Sep 17 00:00:00 2001
From: Aleksander Machniak <alec@alec.pl>
Date: Fri, 26 Apr 2013 11:26:58 +0200
Subject: Fix error handling in CLI mode, use STDERR and non-empty exit code
 (#1489043)

---
 installer/rcube_install.php | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

(limited to 'installer')

diff --git a/installer/rcube_install.php b/installer/rcube_install.php
index b86ccab02..2e1298707 100644
--- a/installer/rcube_install.php
+++ b/installer/rcube_install.php
@@ -637,8 +637,10 @@ class rcube_install
    */
   function update_db($version)
   {
-    system(INSTALL_PATH . "bin/updatedb.sh --package=roundcube --version=" . $version
-      . " --dir=" . INSTALL_PATH . "SQL", $result);
+    system(INSTALL_PATH . "bin/updatedb.sh --package=roundcube"
+      . " --version=" . escapeshellarg($version)
+      . " --dir=" . INSTALL_PATH . "SQL"
+      . " 2>&1", $result);
 
     return !$result;
   }
-- 
cgit v1.2.3