From f790b443353866c25d28bf32fb5bef20e9186aea Mon Sep 17 00:00:00 2001
From: Aleksander Machniak <alec@alec.pl>
Date: Wed, 1 May 2013 12:57:04 +0200
Subject: Small code improvements

---
 program/include/rcmail_output_html.php | 18 ++++++++++++------
 1 file changed, 12 insertions(+), 6 deletions(-)

(limited to 'program/include/rcmail_output_html.php')

diff --git a/program/include/rcmail_output_html.php b/program/include/rcmail_output_html.php
index 0fba66080..02eef2fd1 100644
--- a/program/include/rcmail_output_html.php
+++ b/program/include/rcmail_output_html.php
@@ -760,9 +760,13 @@ class rcmail_output_html extends rcmail_output
 
     /**
      * Parse & evaluate a given expression and return its result.
-     * @param  string Expression statement
+     *
+     * @param string Expression statement
+     *
+     * @return mixed Expression result
      */
-    protected function eval_expression ($expression) {
+    protected function eval_expression ($expression)
+    {
         $expression = preg_replace(
             array(
                 '/session:([a-z0-9_]+)/i',
@@ -784,17 +788,19 @@ class rcmail_output_html extends rcmail_output
             ),
             $expression
         );
-        
+
         $fn = create_function('$app,$browser,$env', "return ($expression);");
-        if(!$fn) {
+        if (!$fn) {
             rcube::raise_error(array(
                 'code' => 505,
                 'type' => 'php',
                 'file' => __FILE__,
                 'line' => __LINE__,
                 'message' => "Expression parse error on: ($expression)"), true, false);
+
+            return null;
         }
-        
+
         return $fn($this->app, $this->browser, $this->env);
     }
 
@@ -980,7 +986,7 @@ class rcmail_output_html extends rcmail_output
 
             // return code for a specified eval expression
             case 'exp':
-                return html::quote( $this->eval_expression($attrib['expression']) );
+                return html::quote($this->eval_expression($attrib['expression']));
 
             // return variable
             case 'var':
-- 
cgit v1.2.3