From 65e735dec541564c01defb58eac326e7369feb7e Mon Sep 17 00:00:00 2001 From: Aleksander Machniak Date: Thu, 12 Mar 2015 20:48:19 +0100 Subject: Fix javascripts errors in IE8 - lack of Event.which, focusing a hidden element (#1490318) --- program/js/list.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'program/js/list.js') diff --git a/program/js/list.js b/program/js/list.js index 9a7f2840e..9c41a12da 100644 --- a/program/js/list.js +++ b/program/js/list.js @@ -151,8 +151,8 @@ init_row: function(row) this.rows[uid] = {uid:uid, id:row.id, obj:row}; // set eventhandlers to table row (only left-button-clicks in mouseup) - row.onmousedown = function(e){ return self.drag_row(e, this.uid); }; - row.onmouseup = function(e){ if (e.which == 1) return self.click_row(e, this.uid); }; + $(row).mousedown(function(e) { return self.drag_row(e, this.uid); }) + .mouseup(function(e) { if (e.which == 1) return self.click_row(e, this.uid); }); if (bw.touch && row.addEventListener) { row.addEventListener('touchstart', function(e) { -- cgit v1.2.3 From 1af5595b901ae0866ad8c80dd23a4cd70ae6e585 Mon Sep 17 00:00:00 2001 From: Aleksander Machniak Date: Sat, 18 Apr 2015 03:04:32 -0400 Subject: Fix mouseup event handling when dragging a list record (#1490359) This fixes drag-n-drop on managesieve filters list. --- program/js/list.js | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) (limited to 'program/js/list.js') diff --git a/program/js/list.js b/program/js/list.js index 9c41a12da..d5a1eb1c7 100644 --- a/program/js/list.js +++ b/program/js/list.js @@ -152,7 +152,12 @@ init_row: function(row) // set eventhandlers to table row (only left-button-clicks in mouseup) $(row).mousedown(function(e) { return self.drag_row(e, this.uid); }) - .mouseup(function(e) { if (e.which == 1) return self.click_row(e, this.uid); }); + .mouseup(function(e) { + if (e.which == 1 && !self.drag_active) + return self.click_row(e, this.uid); + else + return true; + }); if (bw.touch && row.addEventListener) { row.addEventListener('touchstart', function(e) { -- cgit v1.2.3