From 9e4246d9571481fe7b80227b1e23dc013771c5af Mon Sep 17 00:00:00 2001 From: Aleksander Machniak Date: Sun, 16 Nov 2014 14:04:53 +0100 Subject: Code improvements and fixes (mostly unused variables and methods) --- program/lib/Roundcube/rcube_db_oracle.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'program/lib/Roundcube/rcube_db_oracle.php') diff --git a/program/lib/Roundcube/rcube_db_oracle.php b/program/lib/Roundcube/rcube_db_oracle.php index 362beb075..453746446 100644 --- a/program/lib/Roundcube/rcube_db_oracle.php +++ b/program/lib/Roundcube/rcube_db_oracle.php @@ -171,7 +171,7 @@ class rcube_db_oracle extends rcube_db $mode = $this->in_transaction ? OCI_NO_AUTO_COMMIT : OCI_COMMIT_ON_SUCCESS; if ($result) { - foreach ($args as $param => $arg) { + foreach (array_keys($args) as $param) { oci_bind_by_name($result, $param, $args[$param], -1, SQLT_LNG); } } @@ -587,7 +587,7 @@ class rcube_db_oracle extends rcube_db $this->debug('ROLLBACK TRANSACTION'); - if ($result = @oci_rollback($this->dbh)) { + if (@oci_rollback($this->dbh)) { $this->in_transaction = false; } else { -- cgit v1.2.3