From 2a5d02ab8ea2e80d7d73f90b1d31994def0c7c43 Mon Sep 17 00:00:00 2001 From: thomascube Date: Tue, 21 Jul 2009 16:13:42 +0000 Subject: Also protect GET request from CSRF --- program/steps/settings/delete_identity.inc | 17 +++++++++++++---- 1 file changed, 13 insertions(+), 4 deletions(-) (limited to 'program/steps/settings') diff --git a/program/steps/settings/delete_identity.inc b/program/steps/settings/delete_identity.inc index 97c16d578..3d8e2420b 100644 --- a/program/steps/settings/delete_identity.inc +++ b/program/steps/settings/delete_identity.inc @@ -5,7 +5,7 @@ | program/steps/settings/delete_identity.inc | | | | This file is part of the RoundCube Webmail client | - | Copyright (C) 2005-2007, RoundCube Dev. - Switzerland | + | Copyright (C) 2005-2009, RoundCube Dev. - Switzerland | | Licensed under the GNU GPL | | | | PURPOSE: | @@ -19,11 +19,20 @@ */ -if (($ids = get_input_value('_iid', RCUBE_INPUT_GET)) && preg_match('/^[0-9]+(,[0-9]+)*$/', $ids)) +$iid = get_input_value('_iid', RCUBE_INPUT_GPC); + +// check request token +if (!$OUTPUT->ajax_call && !$RCMAIL->check_request(RCUBE_INPUT_GPC)) { + $OUTPUT->show_message('invalidrequest', 'error'); + rcmail_overwrite_action('identities'); + return; +} + +if ($iid && preg_match('/^[0-9]+(,[0-9]+)*$/', $iid)) { - $plugin = $RCMAIL->plugins->exec_hook('delete_identity', array('id' => $ids)); + $plugin = $RCMAIL->plugins->exec_hook('delete_identity', array('id' => $iid)); - if (!$plugin['abort'] && $USER->delete_identity($ids)) { + if (!$plugin['abort'] && $USER->delete_identity($iid)) { $OUTPUT->show_message('deletedsuccessfully', 'confirmation', null, false); } else { -- cgit v1.2.3