From 58fc995728352b466f166a67281b11f6db191f31 Mon Sep 17 00:00:00 2001 From: thomascube Date: Fri, 12 Aug 2011 19:39:39 +0000 Subject: Backport XSS vulnerability fix to 0.5 branch --- program/include/rcube_json_output.php | 14 +++++++++----- program/include/rcube_template.php | 13 +++++++++---- 2 files changed, 18 insertions(+), 9 deletions(-) (limited to 'program') diff --git a/program/include/rcube_json_output.php b/program/include/rcube_json_output.php index cd6b289b2..f9fe38d62 100644 --- a/program/include/rcube_json_output.php +++ b/program/include/rcube_json_output.php @@ -169,12 +169,16 @@ class rcube_json_output public function show_message($message, $type='notice', $vars=null, $override=true) { if ($override || !$this->message) { + if (rcube_label_exists($message)) { + if (!empty($vars)) + $vars = array_map('Q', $vars); + $msgtext = rcube_label(array('name' => $message, 'vars' => $vars)); + } + else + $msgtext = $message; + $this->message = $message; - $this->command( - 'display_message', - rcube_label(array('name' => $message, 'vars' => $vars)), - $type - ); + $this->command('display_message', $msgtext, $type, $timeout * 1000); } } diff --git a/program/include/rcube_template.php b/program/include/rcube_template.php index 5e0f4c14f..9bd9b7a71 100755 --- a/program/include/rcube_template.php +++ b/program/include/rcube_template.php @@ -249,11 +249,16 @@ class rcube_template extends rcube_html_page public function show_message($message, $type='notice', $vars=null, $override=true) { if ($override || !$this->message) { + if (rcube_label_exists($message)) { + if (!empty($vars)) + $vars = array_map('Q', $vars); + $msgtext = rcube_label(array('name' => $message, 'vars' => $vars)); + } + else + $msgtext = $message; + $this->message = $message; - $this->command( - 'display_message', - rcube_label(array('name' => $message, 'vars' => $vars)), - $type); + $this->command('display_message', $msgtext, $type, $timeout * 1000); } } -- cgit v1.2.3