diff options
author | Chad Versace <chad.versace@intel.com> | 2011-01-10 16:55:17 -0800 |
---|---|---|
committer | Chad Versace <chad.versace@intel.com> | 2011-01-10 17:28:24 -0800 |
commit | 4fff52f1c973f2f284c142fbb31536a9656767c9 (patch) | |
tree | 6916f847a33adc7a2b542cad136b91b8162cfd4a /src/glsl/glcpp | |
parent | c0cdae03685056e170c25da7d46aed959176d652 (diff) |
glcpp: Fix segfault when validating macro redefinitions
In _token_list_equal_ignoring_space(token_list_t*, token_list_t*), add
a guard that prevents dereferncing a null token list.
This fixes test src/glsl/glcpp/tests/092-redefine-macro-error-2.c and
Bugzilla #32695.
Diffstat (limited to 'src/glsl/glcpp')
-rw-r--r-- | src/glsl/glcpp/glcpp-parse.y | 21 |
1 files changed, 21 insertions, 0 deletions
diff --git a/src/glsl/glcpp/glcpp-parse.y b/src/glsl/glcpp/glcpp-parse.y index 558ad0acac..148b0ffc7b 100644 --- a/src/glsl/glcpp/glcpp-parse.y +++ b/src/glsl/glcpp/glcpp-parse.y @@ -825,10 +825,31 @@ _token_list_trim_trailing_space (token_list_t *list) } int +_token_list_is_empty_ignoring_space (token_list_t *l) +{ + token_node_t *n; + + if (l == NULL) + return 1; + + n = l->head; + while (n != NULL && n->token->type == SPACE) + n = n->next; + + return n == NULL; +} + +int _token_list_equal_ignoring_space (token_list_t *a, token_list_t *b) { token_node_t *node_a, *node_b; + if (a == NULL || b == NULL) { + int a_empty = _token_list_is_empty_ignoring_space(a); + int b_empty = _token_list_is_empty_ignoring_space(b); + return a_empty == b_empty; + } + node_a = a->head; node_b = b->head; |